Issue #1058 has been updated by luke. Assigned to changed from community to andrew Target version changed from 0.25.0 to 0.24.5 Complexity changed from Unknown to Easy
This is small enough that it should be easy to fix for the next release. ---------------------------------------- Bug #1058: diff printed twice http://reductivelabs.com/redmine/issues/show/1058 Author: wyvern Status: Accepted Priority: Normal Assigned to: andrew Category: RAL Target version: 0.24.5 Keywords: Complexity: Easy Patch: Insufficient Affected version: running puppet with "puppetd --test --noop" I'm seeing the diff shown twice. The full file is also shown (I'm using diff since I _don't_ want the full file - the snmpd.conf file for example is a few thousand lines long!) puppet 0.24.1-2 debian package <pre> 89c89 < [[AllowGroups]] adm backup nagios rbramley abridgett --- > [[AllowGroups]] adm backup nagios rbramley 89c89 < [[AllowGroups]] adm backup nagios rbramley abridgett --- > [[AllowGroups]] adm backup nagios rbramley </pre> I've got as far as a backtrace to find out the two calls which cause this duplication: <pre> content.rb: /etc/ssh/sshd_config /usr/lib/ruby/1.8/puppet/type/pfile/content.rb:47:in @insync?' /usr/lib/ruby/1.8/puppet/metatype/evaluation.rb:148:in @propertychanges' /usr/lib/ruby/1.8/puppet/util.rb:305:in @find_all' /usr/lib/ruby/1.8/puppet/metatype/evaluation.rb:143:in @each' /usr/lib/ruby/1.8/puppet/metatype/evaluation.rb:143:in @find_all' /usr/lib/ruby/1.8/puppet/metatype/evaluation.rb:143:in @propertychanges' /usr/lib/ruby/1.8/puppet/type/pfile.rb:1132:in @propertychanges' /usr/lib/ruby/1.8/puppet/metatype/evaluation.rb:25:in @evaluate' /usr/lib/ruby/1.8/puppet/transaction.rb:60:in @apply' /usr/lib/ruby/1.8/puppet/transaction.rb:240:in @eval_resource' /usr/lib/ruby/1.8/puppet/util.rb:444:in @thinmark' /usr/lib/ruby/1.8/benchmark.rb:293:in @measure' /usr/lib/ruby/1.8/benchmark.rb:307:in @realtime' /usr/lib/ruby/1.8/puppet/util.rb:443:in @thinmark' /usr/lib/ruby/1.8/puppet/transaction.rb:239:in @eval_resource' /usr/lib/ruby/1.8/puppet/transaction.rb:311:in @evaluate' /usr/lib/ruby/1.8/puppet/util.rb:444:in @thinmark' /usr/lib/ruby/1.8/benchmark.rb:293:in @measure' /usr/lib/ruby/1.8/benchmark.rb:307:in @realtime' /usr/lib/ruby/1.8/puppet/util.rb:443:in @thinmark' /usr/lib/ruby/1.8/puppet/transaction.rb:310:in @evaluate' /usr/lib/ruby/1.8/puppet/transaction.rb:304:in @collect' /usr/lib/ruby/1.8/puppet/transaction.rb:304:in @evaluate' /usr/lib/ruby/1.8/puppet/node/catalog.rb:102:in @apply' /usr/lib/ruby/1.8/puppet/network/client/master.rb:260:in @run' /usr/lib/ruby/1.8/puppet/util.rb:212:in @benchmark' /usr/lib/ruby/1.8/benchmark.rb:293:in @measure' /usr/lib/ruby/1.8/benchmark.rb:307:in @realtime' /usr/lib/ruby/1.8/puppet/util.rb:211:in @benchmark' /usr/lib/ruby/1.8/puppet/network/client/master.rb:259:in @run' /usr/lib/ruby/1.8/sync.rb:229:in @synchronize' /usr/lib/ruby/1.8/puppet/network/client/master.rb:241:in @run' /usr/sbin/puppetd:42989c89 < [[AllowGroups]] adm backup nagios rbramley abridgett --- > [[AllowGroups]] adm backup nagios rbramley content.rb: /etc/ssh/sshd_config /usr/lib/ruby/1.8/puppet/type/pfile/content.rb:47:in @insync?' /usr/lib/ruby/1.8/puppet/propertychange.rb:117:in @skip?' /usr/lib/ruby/1.8/puppet/propertychange.rb:72:in @go' /usr/lib/ruby/1.8/puppet/propertychange.rb:109:in @forward' /usr/lib/ruby/1.8/puppet/transaction.rb:119:in @apply_changes' /usr/lib/ruby/1.8/puppet/transaction.rb:111:in @collect' /usr/lib/ruby/1.8/puppet/transaction.rb:111:in @apply_changes' /usr/lib/ruby/1.8/puppet/transaction.rb:83:in @apply' /usr/lib/ruby/1.8/puppet/transaction.rb:240:in @eval_resource' /usr/lib/ruby/1.8/puppet/util.rb:444:in @thinmark' /usr/lib/ruby/1.8/benchmark.rb:293:in @measure' /usr/lib/ruby/1.8/benchmark.rb:307:in @realtime' /usr/lib/ruby/1.8/puppet/util.rb:443:in @thinmark' /usr/lib/ruby/1.8/puppet/transaction.rb:239:in @eval_resource' /usr/lib/ruby/1.8/puppet/transaction.rb:311:in @evaluate' /usr/lib/ruby/1.8/puppet/util.rb:444:in @thinmark' /usr/lib/ruby/1.8/benchmark.rb:293:in @measure' /usr/lib/ruby/1.8/benchmark.rb:307:in @realtime' /usr/lib/ruby/1.8/puppet/util.rb:443:in @thinmark' /usr/lib/ruby/1.8/puppet/transaction.rb:310:in @evaluate' /usr/lib/ruby/1.8/puppet/transaction.rb:304:in @collect' /usr/lib/ruby/1.8/puppet/transaction.rb:304:in @evaluate' /usr/lib/ruby/1.8/puppet/node/catalog.rb:102:in @apply' /usr/lib/ruby/1.8/puppet/network/client/master.rb:260:in @run' /usr/lib/ruby/1.8/puppet/util.rb:212:in @benchmark' /usr/lib/ruby/1.8/benchmark.rb:293:in @measure' /usr/lib/ruby/1.8/benchmark.rb:307:in @realtime' /usr/lib/ruby/1.8/puppet/util.rb:211:in @benchmark' /usr/lib/ruby/1.8/puppet/network/client/master.rb:259:in @run' /usr/lib/ruby/1.8/sync.rb:229:in @synchronize' /usr/lib/ruby/1.8/puppet/network/client/master.rb:241:in @run' /usr/sbin/puppetd:42989c89 < [[AllowGroups]] adm backup nagios rbramley abridgett --- > [[AllowGroups]] adm backup nagios rbramley </pre> ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
