Issue #947 has been updated by plathrop. Status changed from Accepted to Closed % Done changed from 0 to 100 Patch changed from Insufficient to Tests
In the end I was unable to find a reliable way to reproduce this. Closing... ---------------------------------------- Bug #947: pluginsync failure: can't convert nil into String in lib/puppet/network/handler/fileserver.rb:797 http://reductivelabs.com/redmine/issues/show/947 Author: DavidS Status: Closed Priority: High Assigned to: plathrop Category: Target version: 0.25.0 Keywords: Complexity: Unknown Patch: Tests Affected version: When trying to pluginsync with default parameters, current HEAD ([8eecbe54c96cec0de492e7ae77211637b65057e8]) puppetmaster fails with this trace: <pre> debug: mount[plugins]: Listing /plugins for ic.black.co.at ./lib/puppet/network/handler/fileserver.rb:797:in @join' ./lib/puppet/network/handler/fileserver.rb:797:in @file_path' ./lib/puppet/network/handler/fileserver.rb:807:in @reclist' ./lib/puppet/network/handler/fileserver.rb:730:in @list' ./lib/puppet/network/handler/fileserver.rb:152:in @list' /usr/share/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:147:in @to_proc' ./lib/puppet/network/xmlrpc/processor.rb:52:in @call' ./lib/puppet/network/xmlrpc/processor.rb:52:in @protect_service' ./lib/puppet/network/xmlrpc/processor.rb:85:in @setup_processor' /usr/lib/ruby/1.8/xmlrpc/server.rb:336:in @call' /usr/lib/ruby/1.8/xmlrpc/server.rb:336:in @dispatch' /usr/lib/ruby/1.8/xmlrpc/server.rb:323:in @each' /usr/lib/ruby/1.8/xmlrpc/server.rb:323:in @dispatch' /usr/lib/ruby/1.8/xmlrpc/server.rb:366:in @call_method' /usr/lib/ruby/1.8/xmlrpc/server.rb:378:in @handle' ./lib/puppet/network/xmlrpc/processor.rb:44:in @process' ./lib/puppet/network/xmlrpc/webrick_servlet.rb:68:in @service' /usr/lib/ruby/1.8/webrick/httpserver.rb:104:in @service' /usr/lib/ruby/1.8/webrick/httpserver.rb:65:in @run' /usr/lib/ruby/1.8/webrick/server.rb:173:in @start_thread' /usr/lib/ruby/1.8/webrick/server.rb:162:in @start' /usr/lib/ruby/1.8/webrick/server.rb:162:in @start_thread' /usr/lib/ruby/1.8/webrick/server.rb:95:in @start' /usr/lib/ruby/1.8/webrick/server.rb:92:in @each' /usr/lib/ruby/1.8/webrick/server.rb:92:in @start' /usr/lib/ruby/1.8/webrick/server.rb:23:in @start' /usr/lib/ruby/1.8/webrick/server.rb:82:in @start' ./lib/puppet.rb:336:in @start' ./lib/puppet.rb:187:in @newthread' ./lib/puppet.rb:186:in @initialize' ./lib/puppet.rb:186:in @new' ./lib/puppet.rb:186:in @newthread' ./lib/puppet.rb:334:in @start' ./lib/puppet.rb:333:in @each' ./lib/puppet.rb:333:in @start' ./bin/puppetmasterd:281 err: Could not call: can't convert nil into String </pre> I have prodded around the <pre>PluginMount</pre> class and I think the basic problem is that the data structure returned by <pre>Mount.list</pre> is *beep*. This amongst other things causes <pre>relpath = abspath.sub(%r{^#{basepath}}, _)</pre> in <pre>lib/puppet/network/handler/fileserver.rb:PluginMount:reclist()</pre> to not work in all cases, especially when the basepath changes from one module to the next. I have created a little patch that cleans up the [[PluginMount]] class by overriding <pre>list</pre> instead of <pre>reclist</pre> and calling the original <pre>reclist</pre> for each module in turn. This surely needs more love to remove duplicates, but it does work on my puppetmaster now. Please find the patch in the <pre>rest/fix-plugins-mount</pre> branch of my repo at git://git.black.co.at/puppet-bugfixes ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
