Issue #1397 has been updated by luke. Category set to file Status changed from Unreviewed to Accepted Assigned to set to andrew Target version set to 0.24.5 Complexity changed from Unknown to Easy
This is a good idea, although I think it should just raise all exceptions. This is related to a bug posted on the list about connectivity issues causing a later source to be used when multiple sources are specified. We can just raise all exceptions, rather than just specific exceptions. ---------------------------------------- Bug #1397: Better error handling in file source http://reductivelabs.com/redmine/issues/show/1397 Author: jbq Status: Accepted Priority: Normal Assigned to: andrew Category: file Target version: 0.24.5 Keywords: Complexity: Easy Patch: Code Affected version: 0.24.4 I'm having frequent timeout errors reported from my puppet clients in syslog: Jun 27 01:23:41 nc82 puppetd[9089]: Could not call fileserver.describe: #<RuntimeError: HTTP-Error: 408 Request Timeout > Jun 27 01:23:41 nc82 puppetd[9089]: (//Node[nctest_webserver]/Nc_webserver[nc_webserver]/webserver/apache/File[/etc/apache2/aze/access/htpasswd_translators]/source) Could not describe /conf/apache/access/htpasswd_translators: HTTP-Error: 408 Request Timeout Jun 27 01:23:41 nc82 puppetd[9089]: (//Node[nctest_webserver]/Nc_webserver[nc_webserver]/webserver/apache/File[/etc/apache2/aze/access/htpasswd_translators]/ensure) No specified sources exist Jun 27 01:23:41 nc82 puppetd[9089]: (//Node[nctest_webserver]/Nc_webserver[nc_webserver]/webserver/apache/File[/etc/apache2/aze/access/htpasswd_translators]/ensure) No specified sources exist Jun 27 01:23:41 nc82 puppetd[9089]: (//Node[nctest_webserver]/Nc_webserver[nc_webserver]/webserver/apache/File[/etc/apache2/aze/access/htpasswd_translators]/source) No specified sources exist This error is caused by a network hog, which can sometimes happen on my site. In order to be able to filter out the messages from syslog, ideally, Puppet would only issue the first two messages so that I can filter out "408 Request Timeout", and skip this source to avoid the next "No specified sources exist" errors. The specified sources *do* exist, it's just that Puppet failed to request them because of a network failure. Note my clients request the Puppet file server through the wide Internet. Please find attached a patch to address this problem. It raises an exception instead of returning nil in file source's describe method when the error message corresponds to a network problem. ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
