Issue #1237 has been updated by luke.
Status changed from Needs design decision to Closed
Affected version set to 0.24.4
I've fixed this via a similar method; sorry I didn't see this patch ages ago.
The "right" fix, though, was just to quote the constants:
<pre>
describe "Puppet::Network::HTTP::Mongrel", "after initializing" do
confine "Mongrel is not available" => Puppet.features.mongrel?
it "should not be listening" do
require 'puppet/network/http/mongrel'
Puppet::Network::HTTP::Mongrel.new.should_not be_listening
end
end
</pre>
That way there's no problem with having the definitions but not running them.
Otherwise, the code was good. I also fixed the 'confine' code so that confines
on an outer 'describe' get inherited by the nested example groups, so one big
group and one confine at the top is now sufficient.
----------------------------------------
Bug #1237: RSpec tests do not work when Mongrel is not available.
http://reductivelabs.com/redmine/issues/show/1237
Author: porridge
Status: Closed
Priority: Normal
Assigned to: luke
Category: testing
Target version:
Complexity: Unknown
Patch: Tests
Affected version: 0.24.4
Keywords:
If you try, you get errors such as:
<pre>
/home/porridge/Desktop/coding/puppet-git/spec/../lib/puppet/network/http/mongrel/rest.rb:3:
uninitialized constant Mongrel (NameError)
from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in
@gem_original_require'
from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in @require'
from
/home/porridge/Desktop/coding/puppet-git/spec/../lib/puppet/network/http/mongrel.rb:3
from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in
@gem_original_require'
from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in @require'
from
/home/porridge/Desktop/coding/puppet-git/spec/../lib/puppet/network/http.rb:13
from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in
@gem_original_require'
from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in @require'
from
/home/porridge/Desktop/coding/puppet-git/spec/unit/network/http/mongrel.rb:7
from
/home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/example_group_runner.rb:14:in
@load'
from
/home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/example_group_runner.rb:14:in
@load_files'
from
/home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/example_group_runner.rb:13:in
@each'
from
/home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/example_group_runner.rb:13:in
@load_files'
from
/home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/options.rb:85:in
@run_examples'
from
/home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec.rb:20:in
@run'
from
/home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner.rb:192:in
@register_at_exit_hook'
</pre>
I'm about to make a patch available in my git repository.
----------------------------------------
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://reductivelabs.com/redmine/my/account
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
