Issue #1519 has been updated by luke.
I just ran the tests and the mocks have now changed:
<pre>
1)
Mocha::ExpectationError in 'Puppet::Util::Checksums when using md5 should use
incremental Digest::MD5 sums to calculate file checksums'
#<Mock:digest>.file('/path/to/my/file') - expected calls: 0, actual calls: 1
/Users/luke/git/puppet/lib/puppet/util/checksums.rb:76:in `checksum_file'
/Users/luke/git/puppet/lib/puppet/util/checksums.rb:20:in `md5_file'
./spec/unit/util/checksums.rb:55:in `send'
./spec/unit/util/checksums.rb:55:
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:19:in
`run'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in
`each'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in
`run'
2)
Mocha::ExpectationError in 'Puppet::Util::Checksums when using sha1 should use
incremental Digest::SHA1 sums to calculate file checksums'
#<Mock:digest>.file('/path/to/my/file') - expected calls: 0, actual calls: 1
/Users/luke/git/puppet/lib/puppet/util/checksums.rb:76:in `checksum_file'
/Users/luke/git/puppet/lib/puppet/util/checksums.rb:49:in `sha1_file'
./spec/unit/util/checksums.rb:55:in `send'
./spec/unit/util/checksums.rb:55:
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:19:in
`run'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in
`each'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in
`run'
Finished in 0.082169 seconds
20 examples, 2 failures
</pre>
----------------------------------------
Feature #1519: Speed up checksumming
http://reductivelabs.com/redmine/issues/show/1519
Author: stevemac
Status: Tests Insufficient
Priority: Normal
Assigned to: luke
Category: fileserving
Target version: unplanned
Complexity: Hard
Affected version: 0.24.4
Keywords:
According to dtrace, checksuming (MD5) takes a lot of time for each catalog
run. Anything that can be done to speed this up would be valuable.
----------------------------------------
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://reductivelabs.com/redmine/my/account
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
