Issue #1636 has been updated by pnasrat.
I've added a test for this, and am about to cherry pick your fix on top of it -
however the duplicated entries in the array look bogus, I'm going to retest
against 0.24.5:
spec unit/network/handler/fileserver.rb
..................F..
1)
'Puppet::Network::Handler::FileServer
Puppet::Network::Handler::FileServer::PluginMount should list a file within a
directory when given the file path with recursion' FAILED
expected: [["/", "file"]],
got: [["/", "file"], ["/", "file"]] (using ==)
./unit/network/handler/fileserver.rb:161:
----------------------------------------
Bug #1636: Regressions in pluginsync mount
http://projects.reductivelabs.com/issues/show/1636
Author: masterzen
Status: Ready for Testing
Priority: High
Assigned to: pnasrat
Category: mount
Target version: 0.24.6
Complexity: Easy
Affected version: 0.24.5
Keywords: pluginsync mount
Regression in latest 0.24.x git head.
Since commit:a30ecf2aeffd71960bd806fb28cd6d1b8adc2452, reclist has one parameter
less, but Puppet::Network::Handler::PluginMount.list wasn't ported to the
new API.
While mounting plugins, reclist wasn't requiring 'file_serving/fileset',
leading to an NameError.
The change to the new API meant that we lost the existance test of plugins
mount directory. It was failing when the client was mounting module plugins that
weren't existing (like facter and no custom facts defined).
Patch available (but not reviewed) at:
http://github.com/masterzen/puppet/tree/regression-fixes
commit:
http://github.com/masterzen/puppet/commit/fb13f3e8bec665aeb5d32368f80db654761bbf65
I assigned this ticket to Paul Nasrat (sorry Paul :-)), so that he can review
my changes on top of his changeset.
----------------------------------------
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://reductivelabs.com/redmine/my/account
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
