Issue #1642 has been updated by luke. Status changed from Needs design decision to Accepted Assigned to changed from luke to pnasrat
What's the design decision to be made? This is definitely a bug. Paul did the original work, so hopefully he can fix this. ---------------------------------------- Bug #1642: forcing to md5 warning always shown, even if already set http://projects.reductivelabs.com/issues/show/1642 Author: bart Status: Accepted Priority: Normal Assigned to: pnasrat Category: Target version: 0.24.6 Complexity: Unknown Affected version: Keywords: Since http://projects.reductivelabs.com/repositories/revision/puppet/e6698c2b8624fe2c2bbeef594318e3e8d932d345 the client always shows a warning about forcing the checksum to md5 when source has been set, even when the checksum has already (implicitly or explicitly) been set to md5: <pre> $ cat test.pp #!/usr/bin/env puppet file { "/tmp/target": source => "file:///tmp/source", checksum => "md5", } $ ./test.pp warning: //File[/tmp/target]/checksum: Files with source set must use md5 as checksum. Forcing to md5 from md5 for /tmp/target warning: //File[/tmp/target]/checksum: Files with source set must use md5 as checksum. Forcing to md5 from md5 for /tmp/target </pre> This seems to fix it: <pre> --- puppet/type/file/checksum.rb.old 2008-10-09 19:40:28.000000000 +0200 +++ puppet/type/file/checksum.rb 2008-10-09 19:40:15.000000000 +0200 @@ -53,7 +53,7 @@ else if FileTest.directory?(@resource[:path]) return :time - elsif @resource[:source] + elsif @resource[:source] and not %w{md5 md5lite}.include?(value.to_s) self.warning("Files with source set must use md5 as checksum. Forcing to md5 from %s for %s" % [ value, @resource[:path] ]) return :md5 else </pre> I'm assuming md5lite is also valid, but I'm not sure. ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
