Issue #1460 has been updated by immerda.
lutter wrote: > James asked me to summarize what we discussed on IRC yesterday: > > * there's no need to introduce PUPPETMASTER_PID_DIR as a variable in sysconfig > * the way RETVAL is accumulated (RETVAL=$? || $RETVAL) is wrong; it needs to > be 'ret=$?; [ $ret != 0 ] && RETVAL=$ret' > * make sure that 'status' still works and lists all the instances in the > multiport case (similar to 'service nfs status') I rebased the patch and addressed the problems you mentioned in commit: commit "32f40e9":http://github.com/duritong/puppet/commit/32f40e933cfd1d109d2fc93fd14e811a93b2fa3b the commit have been pushed to "tickets/0.24.x/1460":http://github.com/duritong/puppet/commits/tickets/0.24.x/1460 One thing that appeared on the same time on the mailing list is, that this feature enhancement won't work on rhel/centos versions prior to 5. I have addressed that in a comment where the settings are done to start puppetmaster as mongrel cluster. The main problem for this issue is on both sides (rhel/centos rc-functions and puppetmaster): - every puppetmaster instance has to be started with a different pid file. otherwise the cluster setup won't work and only one puppetmaster instance will be started. - rc-functions prior to rhel/centos 5 doesn't support calling killproc (to stop) and status with a specific pidfile. Therefor we're not able to address each instance of the cluster directly over its pidfile. And as rc-functions assumes only one daemon to be started at once, we have no possibility to address the different instances with the rc-functions. I dunno if we'd like to introduce such a version incompatibility, on the other side I think most people are running puppetmaster in a mongrel cluster and therefor an init.d-script which is aware of this possibility would be nice. An option would be to provide a different init-script for the different versions. so an old only single instance script for versions prior to 5 and the enhanced script for versions >= 5. On the other side I would see the comment in sysconfig to be sufficient. But I don't know the packaging rules for fedora/rhel for such cases. I would therefor propose we'll introduce this patch into 0.24.6. However I'm not the person to decide that, so I'll leave this ticket on "Needs design decision". But I think that we can talk about that even if the patch is already in some rc for 0.24.6 and still can remove it later, not? ---------------------------------------- Feature #1460: enhance redhat puppetmaster init.d script to easy start puppetmaster as a mongrel cluster http://projects.reductivelabs.com/issues/show/1460 Author: immerda Status: Needs design decision Priority: Normal Assigned to: lutter Category: Red Hat Target version: 0.24.6 Complexity: Unknown Patch: None Affected version: 0.24.5 Keywords: red hat init script mongrel cluster mongrel_cluster If you'd like to run puppetmaster in a mongrel cluster you have to start X instances of puppetmaster with servertype set to mongrel. With this patch you can add more than one port to the sysconfig file and puppetmaster will automatically be started with severtype set to mongrel. You can now even specify an alternate port in the sysconfig file on which puppetmaster should be run as webrick based server. See sysconfig file for more documentation. ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
