Issue #1696 has been updated by andrew.
There are no tests for this. (not just for the patch, at all) I think I can get them spec'd up this week. Not knowing anything at all about branded zones (and not much more about zones for that matter) it's hard for me to judge what is the most appropriate way to manage them. But... I think it is worth exploring managing these with a little more semantic detail. The commands should not be a single 'space' delimited string, at least pass in any array. The zone provider also has no way to really manage zone attributes. It looks like the management is only one direction and can't go back to change the attributes of a zone that already exists. That's a limitation for the moment, but solving that generically seems like a good idea. (but probably not for this simple patch.) I'd like to talk with coneill about what the command actually look like and then decide if it makes sense to break them out into parameters in the type. ---------------------------------------- Feature #1696: Add support for branded zones http://projects.reductivelabs.com/issues/show/1696 Author: coneill Status: Accepted Priority: Normal Assigned to: andrew Category: Solaris Target version: 0.24.7 Complexity: Unknown Affected version: 0.24.5 Keywords: This patch adds two new parameters on the zone type, and the backing provider support. The parameters are create_args and install_args. These are passed to the zonecfg create and zoneadm install commands, respectively. I implemented these so that I could create solaris8 branded zones, but it's probably useful for other things, including linux branded zones, and anything else you'd want to pass these arguments in for. ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
