Issue #1750 has been updated by mpainter.

File puppet-ensure.diff added
Status changed from Closed to Re-opened

I tested from git head today, and it doesn't behave as I'd expect.

With something like:
file { "foo":
  path    => "/tmp/foo",
  target  => "/lib",
  ensure  => link,
  replace => false,
}

If /tmp/foo already exists as a file, it is removed (without actually creating 
the symlink).  If /tmp/foo exists as a directory it is left alone but there is 
an error message.

Source and content look to be fine, I've attached a patch for insync? in  
ensure.rb which I believe resolves the bug.
----------------------------------------
Bug #1750: When replace => false, do not try to remove existing files.
http://projects.reductivelabs.com/issues/show/1750

Author: mpainter
Status: Re-opened
Priority: Normal
Assigned to: luke
Category: file
Target version: 0.24.7
Complexity: Unknown
Affected version: 0.24.1
Keywords: 


If I have a File with ensure=>link and replace=>false, and it already exists as 
a directory, puppet correctly does not change the directory, but also logs an 
error about not being able to remove the existing directory.

I have only tested this on 0.24.1 (with the patch in ticket 1235).  The 
attached patch is against a git clone from today.


----------------------------------------
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to