Issue #1853 has been updated by luke. Status changed from Needs design decision to Code Insufficient Assigned to deleted (luke)
The code mostly looks good, but the indentation seems essentially arbitrary. We use 4space indentation, so updating to that would be good. Also, please provide tests. They should be pretty straightforward, and I believe there are already examples in the spec/unit/provider/package directory you can use. ---------------------------------------- Feature #1853: pacman package provider http://projects.reductivelabs.com/issues/show/1853 Author: miah Status: Code Insufficient Priority: Low Assigned to: Category: package Target version: 0.25.0 Complexity: Unknown Affected version: 0.24.7 Keywords: archlinux pacman In my efforts to get Puppet working with Archlinux, I've created a package provider for Pacman. I've done a bit of testing with it and it appears to work but I am a ruby novice so there may be some issues. I mostly used the other package providers as examples and reused some existing code. It was definitely fun and frustrating creating this =) - I took a look at adding tests for it, but I am at a loss, the only thing I see is adding package info to the testpackages.yaml file. Please let me know if this is correct or if I need to do something else. - The formatting of the file is a bit rough, is there a standard intentation for Puppet? - I also have a small patch for facter that allows it to detect if the system is Archlinux. I'll submit a seperate ticket with that patch in the facter mine. ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
