On Mar 7, 2009, at 8:12 AM, Nigel Kersten wrote: > > Does this indicate we need a feature to indicate whether a given > provider can have a manual stop command?
It probably does. Really, the existing arrangement for services should be refactored. They were the second resource type to need providers (packages being the first), so their structure is pretty old, and I've never updated it with features or anything. I think the big reason the Red Hat service provider had that bug is that the bug is the most obvious way to handle stop/start, but it's incorrect because of methods in the base class. I think, instead, we should pull most of the base functionality into modules, and based on the presence of features or something, include them. But then, it's not exactly a priority, either. > > On Sat, Mar 7, 2009 at 5:46 AM, James Turnbull <[email protected] > > wrote: >> >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Nigel Kersten wrote: >>> I'm not convinced that there is any utility in the launchd service >>> provider supporting a "stop" command. >>> >>> There are a few moving parts behind the scenes that almost guarantee >>> that if you're needing to specify commands manually, you should be >>> using the base provider, not launchd. >>> >> >> Sure. Not fussed if it isn't needed - more just highlighted the two >> providers that currently have the same logic issue as the Red Hat >> one. >> >> Regards >> >> James >> >> - -- >> Author of: >> * Pulling Strings with Puppet >> (http://www.amazon.com/gp/product/1590599780/) >> * Pro Nagios 2.0 >> (http://www.amazon.com/gp/product/1590596099/) >> * Hardening Linux >> (http://www.amazon.com/gp/product/1590594444/) >> >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v1.4.7 (Darwin) >> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org >> >> iD8DBQFJsnqY9hTGvAxC30ARAl79AJ9weYtHRGV4sQB7bi+knCLVCz+PoQCgzuAl >> QiriWRSILT3nL2RbcSUC79g= >> =pgVp >> -----END PGP SIGNATURE----- >> >>> >> > > > > -- > Nigel Kersten > Systems Administrator > Tech Lead - MacOps > > > -- A motion to adjourn is always in order. --Robert Heinlein --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
