Issue #2291 has been updated by Paul Nasrat. Status changed from Accepted to Ready for Checkin
Github - git://github.com/pnasrat/facter.git tickets/master/2291 Before Patch 1: [pnas...@localhost facter]$ ruby -Ilib bin/facter operatingsystemrelease 4.7 (Final) After [pnas...@localhost facter]$ ruby -Ilib bin/facter operatingsystemrelease 4.7 Edited /etc/redhat-release to be 4.5 (Final) [pnas...@localhost facter]$ rpm -q centos-release centos-release-4-7 [pnas...@localhost facter]$ ruby -Ilib bin/facter operatingsystemrelease 4.7 Switched to branch "tickets/master/2291" [pnas...@localhost facter]$ ruby -Ilib bin/facter operatingsystemrelease 4.5 ---------------------------------------- Bug #2291: Fix operatingsystemrelease for CentOS < 5 http://projects.reductivelabs.com/issues/2291 Author: Paul Nasrat Status: Ready for Checkin Priority: Normal Assigned to: Paul Nasrat Category: Target version: 1.5.5 Complexity: Unknown Keywords: >From irc: On older CentOS releases, a sed command is used to parse the release number from /etc/redhat-release. However, the command lacked the proper amount of backslashes to escape the parenthesis. Also The previous check for /5/ matched releases like 4.5, which is not the intent. The previous check was introduced in 095eb15e, and changed the pattern from /^5^/. Using /^5/ to match when the release begins with 5 seems saner. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
