Issue #2211 has been updated by John Florian.
Just wanted to mention that I spent too much time yesterday trying to come up with a patch for this. Ruby has just too many subtle "features" for me (a Ruby newb) to get a working patch here with a reasonable effort. So instead, I thought I'd share some findings. # Facter.exec cannot just return the output and PID together since if the read on the popen pipe blocks and the call to exec never returns and consequently Facter.value won't know what PID to reap. This is exactly the case we're trying to fix. # You could make the PID an instance variable so that Facter.exec can set it before reading from the pipe. That way Facter.value could access the correct PID value. (I tried this, but stumbled on Ruby's variable scoping and what may be pubic/private/static methods -- I bet it would be easy for someone fluent in Ruby though.) # You could also just inline the Facter.exec code within Facter.value. ---------------------------------------- Bug #2211: puppet won't install packages if network interface does not have an IP address bound http://projects.reductivelabs.com/issues/2211 Author: John Florian Status: Accepted Priority: High Assigned to: Luke Kanies Category: Target version: 0.25.0 Complexity: Unknown Affected version: 0.24.8 Keywords: It is no longer possible to have puppet install packages via yum/rpm if the network interface is not bound to an IP address. Our use case requires using puppet in the non-daemon mode and this is possible for us because the system will have all necessary manifests and other necessary files locally. This worked just fine with 0.24.6 on Fedora 10, but began failing upon the upgrade to 0.24.8. See the attachments for failure messages and a code diff that seems to have introduced the regression. If I revert this one change, things work nicely once again. Looks like a very simple fix if it weren't for the ominous looking comment in the code. :-) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
