Issue #2330 has been updated by Paul Nasrat. Status changed from Accepted to Code Insufficient
I reviewed this on list, but I'm updating this to get to the original patch author. i Generally if we're doing more complex facts we should have tests. Also the patch as is won't work as it's doing assignment (single equals) in conditionals not comparison (==). If you can fix up the logic and update this bug that'd be great, if you want advise on how to test please ask on the dev list. ---------------------------------------- Refactor #2330: Uptime gets computed twice on systems with /proc/uptime http://projects.reductivelabs.com/issues/2330 Author: Felix Schäfer Status: Code Insufficient Priority: Normal Assigned to: Category: library Target version: 1.6.0 On systems with /proc/uptime, the uptime gets computed once by reading said file, and once by calling uptime itself. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
