Issue #2350 has been updated by Luke Kanies. Assigned to deleted (Luke Kanies)
James Turnbull wrote: > Does this means you're happy with this Luke? I'm happy with it if someone tests it. I'd like to see at least one person who heavily uses apt to test this. ---------------------------------------- Bug #2350: Aptitude Provider installs newest version when it can't find the specified one, also doesn't detect several errors http://projects.reductivelabs.com/issues/2350 Author: Clarence Tso Status: Ready for Testing Priority: Normal Assigned to: Category: package Target version: 0.25.0 Complexity: Unknown Affected version: 0.24.8 Keywords: aptitude provider package version While using the Aptitude provider, I found that if you specify a version that Aptitude can't find, it tells you this but then just goes ahead and installs the latest version. I fixed this by making a dry run to install the package and then checking whether it could find it or not, throwing a Puppet error if it can't find the version. The dry run is necessary, or else aptitude would install it before we can detect that the wrong version was installed. On a related note, I also added extra stdout checks to look for cases of unmet dependencies and 404's from the user's sources. These are all problems I ran into when using the Aptitude provider. With these fixes, the user is less likely to think that the package was installed when it wasn't (due to uncaught errors), and will also be assured of what package version they are using. I've submitted my git patch. I originally did this in subversion (just started using git, total nub in that respect) based on puppet-latest.tgz (got 0.24.8), but figured a git patch would be more appropriate, so I forked + cloned lak/puppet/, made the changes there, and created the patch. I don't have tests, but I've been using the puppet-latest.tgz-modified version on my production servers for the last month. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
