Issue #2261 has been updated by Luke Kanies.

Status changed from Needs more information to Accepted
Assigned to changed from Simon Kuhn to Brice Figureau

Yeah, I think we should CGI escape everything.
----------------------------------------
Bug #2261: sshkey replaces + with space
http://projects.reductivelabs.com/issues/2261

Author: Simon Kuhn
Status: Accepted
Priority: Normal
Assigned to: Brice Figureau
Category: ssh
Target version: 0.25.0
Complexity: Unknown
Affected version: 0.25.0
Keywords: 


puppet-0.25.0beta1
ruby-1.8.7.72
OS: Ubuntu 9.04 amd64

This manifest:
<pre>
class ssh::hostkey {
        @@sshkey { "$hostname": type => rsa, key => $sshrsakey, alias => $fqdn }
        Sshkey <<| |>>
}
</pre>
yields:
<pre>
hostname,hostname.domain ssh-rsa 
AAAAB3NzaC1yc2EAAAABIwAAAQEAzbtin9E/YQFWqnO7WSDakQ9HZCkkOpi4Iyrnrd4Y  
I6InJJhR/K17bLmQUH6quGJtFZ8Q2rulou9jn4O 
oAadGuaImFLlVHBIXu/rRCzl1IV22P6m4aW9yMZ0OaehhT0rs 
jpomrYpD4lcSxhsvDWAccyrHIF3ipdbBWQZsMjO8hUGuvKa68CYd9MLl8Cnb3a 
h6Un4mGmqUygL56ZhSQ83VI9aCqTv1FRfZr4HAj86fxf204efR 
T4Q0r8esVjhb0rCBmLVb/PZ8nLsaztGyIC8 ApK8DxsRi7ZRApKSAlJReQOq2mp0v8kg WwTpnz 
xW7vlGVPSTMka5dx0hrw==
</pre>
Note that there are spaces. These are +'s in the original file and in facter.


Simply downgrading to 0.24.8 appears to resolve the issue. After downgrading 
and restarting puppet/puppetmaster:
<pre>
May 14 00:15:18 ubuntu puppetd[3254]: 
(//Node[default]/ssh::server/Sshkey[hostname]/key) key changed 
'AAAAB3NzaC1yc2EAAAABIwAAAQEAzbtin9E/YQFWqnO7WSDakQ9HZCkkOpi4Iyrnrd4Y 
I6InJJhR/K17bLmQUH6quGJtFZ8Q2rulou9jn4O 
oAadGuaImFLlVHBIXu/rRCzl1IV22P6m4aW9yMZ0OaehhT0rs 
jpomrYpD4lcSxhsvDWAccyrHIF3ipdbBWQZsMjO8hUGuvKa68CYd9MLl8Cnb3a 
h6Un4mGmqUygL56ZhSQ83VI9aCqTv1FRfZr4HAj86fxf204efR 
T4Q0r8esVjhb0rCBmLVb/PZ8nLsaztGyIC8 ApK8DxsRi7ZRApKSAlJReQOq2mp0v8kg WwTpnz 
xW7vlGVPSTMka5dx0hrw==' to 
'AAAAB3NzaC1yc2EAAAABIwAAAQEAzbtin9E/YQFWqnO7WSDakQ9HZCkkOpi4Iyrnrd4Y++I6InJJhR/K17bLmQUH6quGJtFZ8Q2rulou9jn4O+oAadGuaImFLlVHBIXu/rRCzl1IV22P6m4aW9yMZ0OaehhT0rs+jpomrYpD4lcSxhsvDWAccyrHIF3ipdbBWQZsMjO8hUGuvKa68CYd9MLl8Cnb3a+h6Un4mGmqUygL56ZhSQ83VI9aCqTv1FRfZr4HAj86fxf204efR+T4Q0r8esVjhb0rCBmLVb/PZ8nLsaztGyIC8+ApK8DxsRi7ZRApKSAlJReQOq2mp0v8kg+WwTpnz+xW7vlGVPSTMka5dx0hrw=='
</pre>
It would also appear that a 0.24.8 client -> 0.25.0beta1 puppermaster yields 
the correct results.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to