Issue #2438 has been updated by Nigel Kersten. Status changed from Accepted to Ready for Checkin
http://github.com/nigelkersten/puppet/tree/tickets/0.25.x/2438 http://github.com/nigelkersten/puppet/commit/835dfe0233c29aff3b7430a8d36a821f77aa8db4 ---------------------------------------- Bug #2438: directoryservice provider should use facter supplied major OS X version rather than doing it itself http://projects.reductivelabs.com/issues/2438 Author: Nigel Kersten Status: Ready for Checkin Priority: Normal Assigned to: Nigel Kersten Category: Target version: Complexity: Easy Affected version: 0.25.0 Keywords: <pre> def self.get_macosx_version_major if defined? @macosx_version_major return @macosx_version_major end begin product_version = Facter.value(:macosx_productversion) if product_version.nil? raise Puppet::Error, "Could not determine OS X version from Facter" end product_version_major = product_version.scan(/(\d+)\.(\d+)./).join(".") if %w{10.0 10.1 10.2 10.3}.include?(product_version_major) raise Puppet::Error, "%s is not supported by the directoryservice provider" % product_version_major end @macosx_version_major = product_version_major return @macosx_version_major rescue Puppet::ExecutionFailure => detail raise Puppet::Error, "Could not determine OS X version: %s" % detail end end </pre> None of this code should really exist as is now that Facter is supplying the major/minor version as a discrete fact -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
