Issue #2541 has been updated by Markus Roberts.
Status changed from Accepted to Needs design decision
Assigned to changed from Markus Roberts to Luke Kanies
Ok, some clarity. The two tests in question (which I wrote) should have been
failing all along but were not due to an interaction with prior tests.
So now the question is, are the tests faulty (trying to ensure an incorrect
behavior) or are the tests right (and thus there are two more capitalization
issues analogous to #2493 that need to be fixed)? Either case is easy to deal
with, but I lack the global knowledge to decide between them.
Specifically:
1. If the file "MyThing.rb" defines @mything@ should the autoloader find it?
If not, the test should be removed. If so, the logic of
lib/puppet/util/autoload.rb load() around line 80 will need to be reworked.
2. If the file "includedclass" contains @class includedclass {}@ should a
reference to @IncludedClass@ find it?
If not, the test should be removed. If so, line ~378 in
lib/puppet/resource/catalog.rb should be changed from
ref = Puppet::Resource::Reference.new(type, title).to_s
to
ref = Puppet::Resource::Reference.new(type,
title.to_s.downcase.intern).to_s
----------------------------------------
Bug #2541: Possible regression in autoload case sensitivity
http://projects.reductivelabs.com/issues/2541
Author: Markus Roberts
Status: Needs design decision
Priority: Normal
Assigned to: Luke Kanies
Category:
Target version: 0.25.0
Complexity: Unknown
Affected version: 0.25.0
Keywords:
While working on #2520 this evening I started getting the following errors
which now seem persistent:
<pre>
1)
'Puppet::Util::Autoload should successfully load a file with a mixed case name'
FAILED
expected true, got false
./spec/integration/util/autoload.rb:75:
./spec/integration/util/autoload.rb:33:in `with_file'
./spec/integration/util/autoload.rb:74:
./spec/integration/util/autoload.rb:44:in `with_loader'
./spec/integration/util/autoload.rb:73:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
2)
'the include function should find a file with an all lowercase name given a
mixed case name' FAILED
expected true, got false
./spec/integration/parser/functions/require.rb:71:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
</pre>
I have been pulling and installing HEAD regularly.
This may be related to #2493 (an analogous bug, or regression caused by the
fix) or it may be independent. It may even be a test-ordering problem. I'm at
the end of my cognitively effective day; I'll look at it more tomorrow.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://reductivelabs.com/redmine/my/account
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
