Issue #2520 has been updated by Markus Roberts. Status changed from Code Insufficient to Ready for Testing
James -- All of the errors fall into one of two categories and could be plausibly explained by either 1) older code being tested or 2) a mix of older and newer code being tested. Further, we now know that under some circumstances the spec process will load code from the installed version of puppet, which could plausibly create such an old code/new code hybrid. While this is not conclusive, there are a few things we could do to test the hypothesis. # Run "sudo ruby install.rb" prior to performing the tests (to make sure the same code is being executed, regardless of the location) and retry. Obviously, don't do this on a box that needs to have a specific version of puppet installed. # Unistall puppet by removing the .../site_ruby/1.8/puppet directory (same caveats) and retest # Set me up with an environment that exhibits the problems so I can poke at to try to narrow it down from the other end (see my e-mail) -- Markus ---------------------------------------- Bug #2520: Broken tests in Puppet 0.25.x HEAD http://projects.reductivelabs.com/issues/2520 Author: James Turnbull Status: Ready for Testing Priority: Normal Assigned to: James Turnbull Category: testing Target version: 0.25.0 Complexity: Unknown Affected version: 0.25.0rc1 Keywords: <pre> 1) Mocha::ExpectationError in 'Puppet::Indirector::Queue when saving should catch any exceptions raised' not all expectations were satisfied unsatisfied expectations: - expected exactly once, not yet invoked: #<Puppet::Indirector::Queue::TestClient:0x7f56d0dc6d28>.send_message(any_parameters) satisfied expectations: - allowed any number of times, not yet invoked: #<Mock:indirection>.register_terminus_type(any_parameters) - allowed any number of times, not yet invoked: #<Mock:indirection>.model(any_parameters) - allowed any number of times, already invoked 4 times: #<Mock:indirection>.name(any_parameters) - allowed any number of times, already invoked once: Puppet::Indirector::Indirection.instance(:my_queue) - allowed any number of times, already invoked once: #<Puppet::Util::Settings:0x7f56d4d0efd0>.value(:queue_type) - allowed any number of times, not yet invoked: #<Puppet::Util::Settings:0x7f56d4d0efd0>.value(any_parameters) - allowed any number of times, already invoked once: Puppet::Util::Queue.queue_type_to_class(:test_client) - allowed any number of times, already invoked twice: #<Mock:request>.key(any_parameters) - allowed any number of times, already invoked twice: #<Mock:request>.instance(any_parameters) ./spec/unit/indirector/queue.rb:81: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 2) 'Puppet::Type::File when writing files should fail if no backup can be performed' FAILED expected: "bar\n", got: "foo" (using ==) ./spec/integration/type/file.rb:54: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 3) JSON::ParserError in 'Puppet::Resource::Catalog when converting to json should set its json_class to 'Puppet::Resource::Catalog'' source did not contain any JSON! ./spec/unit/resource/catalog.rb:887: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 4) JSON::ParserError in 'Puppet::Resource::Catalog when converting to json should set its data as a hash' source did not contain any JSON! ./spec/unit/resource/catalog.rb:892: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 5) JSON::ParserError in 'Puppet::Resource::Catalog when converting to json should set its name to the name of the resource' source did not contain any JSON! ./spec/unit/resource/catalog.rb:900: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 6) JSON::ParserError in 'Puppet::Resource::Catalog when converting to json should set its version to the version of the resource' source did not contain any JSON! ./spec/unit/resource/catalog.rb:900: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 7) JSON::ParserError in 'Puppet::Resource::Catalog when converting to json should set its tags to the tags of the resource' source did not contain any JSON! ./spec/unit/resource/catalog.rb:900: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 8) JSON::ParserError in 'Puppet::Resource::Catalog when converting to json should convert its resources to a JSON-encoded array and store it as the 'resources' data' source did not contain any JSON! ./spec/unit/resource/catalog.rb:913: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 9) JSON::ParserError in 'Puppet::Resource::Catalog when converting to json should convert its edges to a JSON-encoded array and store it as the 'edges' data' source did not contain any JSON! ./spec/unit/resource/catalog.rb:928: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 10) SystemExit in 'Puppet::Network::Server when using webrick after unlistening should not be reachable on the port and address assigned' exit /home/james/src/puppet/spec/../lib/puppet/application/puppetmasterd.rb:36:in `exit' /home/james/src/puppet/spec/../lib/puppet/application/puppetmasterd.rb:36:in `run_preinit' /home/james/src/puppet/spec/../lib/puppet/network/http/webrick.rb:48:in `call' /home/james/src/puppet/spec/../lib/puppet/network/http/webrick.rb:48:in `join' /home/james/src/puppet/spec/../lib/puppet/network/http/webrick.rb:48:in `unlisten' /home/james/src/puppet/spec/../lib/puppet/network/http/webrick.rb:45:in `synchronize' /home/james/src/puppet/spec/../lib/puppet/network/http/webrick.rb:45:in `unlisten' /home/james/src/puppet/spec/../lib/puppet/network/server.rb:136:in `unlisten' ./spec/integration/network/server/webrick.rb:81: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 11) ArgumentError in 'Puppet::Relationship when converting to json should set the 'json_class' to Puppet::Relationship' wrong number of arguments (2 for 1) /home/james/src/puppet/lib/puppet/relationship.rb:90:in `to_json' ./spec/unit/relationship.rb:174: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 12) ArgumentError in 'Puppet::Relationship when converting to json should store the stringified source as the source in the data' wrong number of arguments (2 for 1) /home/james/src/puppet/lib/puppet/relationship.rb:90:in `to_json' ./spec/unit/relationship.rb:180: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 13) ArgumentError in 'Puppet::Relationship when converting to json should store the stringified target as the target in the data' wrong number of arguments (2 for 1) /home/james/src/puppet/lib/puppet/relationship.rb:90:in `to_json' ./spec/unit/relationship.rb:186: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 14) ArgumentError in 'Puppet::Relationship when converting to json should store the jsonified event as the event in the data' wrong number of arguments (2 for 1) /home/james/src/puppet/lib/puppet/relationship.rb:90:in `to_json' ./spec/unit/relationship.rb:193: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 15) ArgumentError in 'Puppet::Relationship when converting to json should not store an event when none is set' wrong number of arguments (2 for 1) /home/james/src/puppet/lib/puppet/relationship.rb:90:in `to_json' ./spec/unit/relationship.rb:200: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 16) ArgumentError in 'Puppet::Relationship when converting to json should store the jsonified callback as the callback in the data' wrong number of arguments (2 for 1) /home/james/src/puppet/lib/puppet/relationship.rb:90:in `to_json' ./spec/unit/relationship.rb:207: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 17) ArgumentError in 'Puppet::Relationship when converting to json should not store a callback when none is set in the edge' wrong number of arguments (2 for 1) /home/james/src/puppet/lib/puppet/relationship.rb:90:in `to_json' ./spec/unit/relationship.rb:214: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 18) Puppet::Error in 'Puppet::SSL::CertificateRequest should be able to save CSRs' Cannot save luke.madstop.com; parent directory /tmp/csr_integration_testing.26845.0/ssl/ca/requests does not exist /home/james/src/puppet/lib/puppet/indirector/ssl_file.rb:95:in `save' /home/james/src/puppet/spec/../lib/puppet/indirector/certificate_request/ca.rb:10:in `save' /home/james/src/puppet/lib/puppet/indirector/indirection.rb:258:in `save' /home/james/src/puppet/lib/puppet/indirector.rb:65:in `save' /home/james/src/puppet/lib/puppet/ssl/certificate_request.rb:44:in `save' ./spec/integration/ssl/certificate_request.rb:43: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 19) Puppet::Error in 'Puppet::SSL::CertificateRequest should be able to find saved certificate requests via the Indirector' Cannot save luke.madstop.com; parent directory /tmp/csr_integration_testing.26845.0/ssl/ca/requests does not exist /home/james/src/puppet/lib/puppet/indirector/ssl_file.rb:95:in `save' /home/james/src/puppet/spec/../lib/puppet/indirector/certificate_request/ca.rb:10:in `save' /home/james/src/puppet/lib/puppet/indirector/indirection.rb:258:in `save' /home/james/src/puppet/lib/puppet/indirector.rb:65:in `save' /home/james/src/puppet/lib/puppet/ssl/certificate_request.rb:44:in `save' ./spec/integration/ssl/certificate_request.rb:48: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' 20) Puppet::Error in 'Puppet::SSL::CertificateRequest should save the completely CSR when saving' Cannot save luke.madstop.com; parent directory /tmp/csr_integration_testing.26845.0/ssl/ca/requests does not exist /home/james/src/puppet/lib/puppet/indirector/ssl_file.rb:95:in `save' /home/james/src/puppet/spec/../lib/puppet/indirector/certificate_request/ca.rb:10:in `save' /home/james/src/puppet/lib/puppet/indirector/indirection.rb:258:in `save' /home/james/src/puppet/lib/puppet/indirector.rb:65:in `save' /home/james/src/puppet/lib/puppet/ssl/certificate_request.rb:44:in `save' ./spec/integration/ssl/certificate_request.rb:55: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run' Finished in 1497.263173 seconds 6897 examples, 20 failures, 24 pending Loaded suite /usr/bin/rcov </pre> This is at commit:"a88fc4d24c50d91aa764fa8f52797e86bb6d8965". -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
