Issue #2810 has been updated by Brice Figureau.

Markus Roberts wrote:
> I'm directing this to James because he accepted the ticket, but anyone else 
> who knows is free to answer.
> 
> This looks like a simple deprecation issue (not a bug).  We used to permit 
> numeric values for recurse, but that was problematic as there was actually 
> more information required, so it was split into two parameters (recurse and 
> recurselimit) with recurselimit being the numeric part and recurse 
> determining where (master, server, neither or both).  The error message 
> appears to say as much: use recurselimit instead of recurse.
> 
> What am I missing?
> 
> -- Markus

You're missing that tidy doesn't support both parameters, it only supports 
"recurse". Using recurse with a number in FileSet is not supported anymore.
To make it short: when I introduced the parameter separation, I modified the 
FileSet api, and put the deprecation in the File type. I forgot that there were 
some other use of FileSet, especially in tidy.

So, we have 2 options:

# fix tidy to correctly use FileSet
# enhance tidy to use both parameters: recurse, and recurselimit

I think 1) is better as 2) doesn't add any value (there's no need to have a 
recurse value different than true/false).

----------------------------------------
Bug #2810: tidy resource error: Failed to generate additional resources using 
'generate': Fileset recurse parameter must not be a number anymore, please use 
recurselimit
http://projects.reductivelabs.com/issues/2810

Author: Tim Stoop
Status: Needs more information
Priority: Normal
Assigned to: 
Category: 
Target version: 0.25.2
Affected version: 0.25.1
Keywords: 
Branch: 


Hi,

I use the tidy resource in a lot of places and since 0.25.1 (skipped 0.25.0 so 
I don't know) it's giving me the following error:

err: 
//cust::webserver/Cust::Webserver::Tomcatsite[app]/Kbp-tomcat::Project[app]/Tidy[/srv/tomcat/app/logs/]:
 Failed to generate additional resources using 'generate': Fileset recurse 
parameter must not be a number anymore, please use recurselimit

The tidy resource is very simple:

tidy { "/srv/tomcat/app/logs/":
  matches => "*",
  age => "4w",
  recurse => 1,
}

It's initiated (is that the right term?) form within a define that actually 
also sets the Tomcat instance up and put some other files (munin plugins) in 
place. This worked in 0.24.8. Please let me know if you need additional 
information.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to