Issue #2731 has been updated by Ricky Zhou.
Markus Roberts wrote: > My thought on the patch: > > * Overall, looks plausible > * The change: > [...] > while arguably "the right way to do it" is inconsistent with all other > occurrences and should be rejected on that bases (though I'm going to add > that point to my code smell list). Ah, the reason I made that change was that I was getting inconsistent output from <pre> Puppet::Util.execute(["does_not_exist"], :failonfail => false) </pre> using the original version versus my version. For some reason, my version would return the "No such file or directory..." error while the current version would return a blank string. I'll look more into why this happens. > * I'm not too crazy about adding all the blank lines. I don't know the first thing about ruby style, so if they're not helpful, I'm happy to get rid of them :-) > * This is a much further reaching change than the title suggests > * I'm also concerned about the #662 question, though not as much as I was at > first. For what it's worth, I've finished my testing on Fedora 12, and I was able to reproduce the issue and confirm that the patch fixes it for me. I wasn't able to reproduce on CentOS 5.4 (most likely due to different SELinux policy versions?), but the patch didn't seem to break anything either. Like you said, this seems to be a pretty far-reaching change, so the more scrutiny and testing this gets, the better. Thanks for taking a look at this! ---------------------------------------- Bug #2731: problem communicating with processes in SELinux http://projects.reductivelabs.com/issues/2731 Author: Jonathan Stanton Status: Needs design decision Priority: Normal Assigned to: Category: SELinux Target version: 0.25.2 Affected version: 0.24.8 Keywords: Branch: On a Centos 5.3 system with NFS mounting home directories, every time puppet runs it tries to update the status of the nfs mount from "present" to "mounted" but fails because the call to mount returns -32 not 0. But as documented on the man page -32 means 'already mounted' and so should be treated as success. Here is the logged message from puppetd. <pre> Oct 16 10:28:07 savage-file puppetd[11739]: (//Node[savage-file.livetimenet.com]/nfs_moose_client/Mount[/mnt/moose_home]/ensure) change from present to mounted failed: Execution of '/bin/mount -o rw,async /mnt/moose_home' returned 32: </pre> This has been going on for awhile (certainly back several versions of puppet) and I've tried some ideas with restarting it, and letting puppet do the original mount instead of the OS mounting it directly. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
