Issue #3038 has been updated by Markus Roberts.

Status changed from Unreviewed to Duplicate

This is being addressed as part of the "1.9 portability" refactor in code smell 
cleanup effort.

----------------------------------------
Bug #3038: Ruby 1.9 portability: obsolete when/: syntax
http://projects.reductivelabs.com/issues/3038

Author: Pavel Ivanov
Status: Duplicate
Priority: Normal
Assigned to: 
Category: 
Target version: 
Affected version: development
Keywords: ruby 1.9
Branch: 


Obsolete "when:" syntax on in lib/puppet/rails.rb brakes features checks (and 
possibly smth. else) on ruby 1.9.1:
<pre>
$ ruby -rpuppet -e 'p Puppet.features.ldap?'
Could not autoload compiler: /usr/lib/ruby/site_ruby/1.9.1/puppet/rails.rb:61: 
syntax error, unexpected ':', expecting keyword_then or ',' or ';' or '\n'
/usr/lib/ruby/site_ruby/1.9.1/puppet/indirector/indirection.rb:160:in 
`validate_terminus_class': Could not find terminus compiler for indirection 
catalog (ArgumentError)
<full trace skipped, attached below>

</pre>
Reproduceble right after installing puppet and facter from git on clean system. 
Removing colon as shown in attached patch fixes the issue.

Additionally, quick check by running:
@$ grep -r 'when.*:$' .@
on git repository root gives the following:
<pre>
./ext/puppetlisten/puppetlisten.rb:    when /^\s*(\w+)\s+(.+)$/:
./ext/puppetlisten/puppetlisten.rb:        when "allow":
./tasks/rake/git_workflow.rake:         when nil?:
</pre>
So, supposedly, it may be required to fix these files for ruby1.9 portability, 
too.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to