Issue #3080 has been updated by Bruce Williams. Status changed from Accepted to Ready for Testing Assigned to set to Bruce Williams Priority changed from High to Normal Branch set to http://github.com/bruce/facter/tree/ticket-3080
The failures were caused by a couple issues that may have been limited to OSX (possibly only SL). * The absence of /bin/true caused a couple Resolution.exec tests to fail. Instead of expecting a binary to exist, the exists? check is now stubbed. * Changes to system_profiler output or the Resolution.exec result value type resulted in an exception with the plist parser; the OSX util can now handle an array All tests are now green on my branch. ---------------------------------------- Bug #3080: Fix test failures http://projects.reductivelabs.com/issues/3080 Author: Bruce Williams Status: Ready for Testing Priority: Normal Assigned to: Bruce Williams Category: Target version: Keywords: testing Branch: http://github.com/bruce/facter/tree/ticket-3080 There are a number of test failures on master as of 68fc1235... <pre> 1) 'Facter::Util::Resolution when executing code should produce stderr content as a warning' FAILED expected: "aaa", got: nil (using ==) ./spec/unit/util/resolution.rb:246: 2) 'Facter::Util::Resolution when executing code should produce nil as a warning if nothing is printed to stderr' FAILED expected: "aaa", got: nil (using ==) ./spec/unit/util/resolution.rb:255: 3) NoMethodError in 'Per Interface IP facts should replace the ':' in an interface list with '_'' undefined method `each' for nil:NilClass ./spec/unit/interfaces.rb:9: 4) NoMethodError in 'Facter should delegate the :list method to the collection' undefined method `each' for nil:NilClass ./spec/unit/facter.rb:31: 5) NoMethodError in 'Facter should delegate the :to_hash method to the collection' undefined method `each' for nil:NilClass ./spec/unit/facter.rb:42: 6) NoMethodError in 'Facter should delegate the :each method to the collection' undefined method `each' for nil:NilClass ./spec/unit/facter.rb:58: </pre> This technical debt needs to be paid off. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
