Issue #2341 has been updated by Frank Sorenson.

This bug is not addressed in the available patch, and isn't tested with the 
test case.  The dmidecode output above is still split incorrectly.
----------------------------------------
Bug #2341: Facter::Manufacturer.dmi_find_system_info splits on non-unique 
delimiter
http://projects.reductivelabs.com/issues/2341

Author: Frank Sorenson
Status: Ready for Testing
Priority: Normal
Assigned to: 
Category: library
Target version: 1.5.8
Keywords: 
Branch: 


dmi_find_system_info splits the dmidecode output on 'Handle', however this 
delimiter may also occur within a valid 'line'.  Here is an example of 
dmidecode output:

<pre>
Handle 0x1000, DMI type 16, 15 bytes
Physical Memory Array
        Location: System Board Or Motherboard
        Use: System Memory
        Error Correction Type: None
        Maximum Capacity: 4 GB
        Error Information Handle: Not Provided
        Number Of Devices: 2
</pre>

Which is incorrectly split as:
<pre>
0x1000, DMI type 16, 15 bytes
Physical Memory Array
        Location: System Board Or Motherboard
        Use: System Memory
        Error Correction Type: None
        Maximum Capacity: 4 GB
        Error Information 
</pre>
and
<pre>
 : Not Provided
        Number Of Devices: 2
</pre>

This makes it impossible for the function to locate the final two values.

Changing splitstr to /^Handle/ makes the delimiter split the output correctly.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to