Issue #3093 has been updated by Markus Roberts.

Technically it isn't outside a module (classes, recall, are modules) and the 
block is being used as the body of the class definition for the provider via a 
call to genclass, but you're right that it isn't finding module_function there. 
 This would be a lot easier if I had the ability to test directly (thank you, 
by the way, for your patience and assistance on this).

As for the why, I'm trying to find a solution that minimizes the coupling 
between the levels (or, to look at another way, that shortens the indirection 
path between the call locations and the definition).  Defining what is 
essentially a convenience method in a place that requires most of the calls to 
be of the form blah.foo.bar() is brittle and leads to problems down the road.

I'll fall back to plan B, and post a new version for testing shortly.

----------------------------------------
Bug #3093: Blastwave provider broken in 0.25.3
http://projects.reductivelabs.com/issues/3093

Author: Cody Herriges
Status: Ready for Testing
Priority: High
Assigned to: James Turnbull
Category: Solaris
Target version: 0.25.4
Affected version: 0.25.3
Keywords: 
Branch: http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/3093


We are running a few select OpenSolaris boxes with puppet installed directly 
from Gems and so running 0.25.3 where the rest of our implementation is 0.25.1 
and lower.  I noticed yesterday that the fix for bug #887 which was pushed with 
revision ID: b96b757f1d091130b06542856c5b5b3a683a8e39 has broken the blastwave 
provider.  Puppet errors with no 'method pkgget_with_cat' errors.  This looks 
to be a problem of scope when the variable pkgget was replaced through out the 
provider with the method pkgget_with_cat.  I have attached a patch that makes 
the provider functional again.

This is my first dive into the Puppet source and I am still relatively new to 
Ruby so I would appreciate a quick test and code review.

Thanks,


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to