Jira (PUP-5062) static compiler fails to remove existing resources from children.

[Taylan Develioglu (JIRA)]

Title: Message Title

Taylan Develioglu created an issue   Puppet / PUP-5062 static compiler fails to remove existing resources from children. Issue Type: Bug Assignee: Unassigned Created: 2015/08/21 4:22 AM Priority: Normal Reporter: Taylan Develioglu The static compiler fails to remove child resources that already exist in the catalog. file { '/tmp/statically_compiled': ensure => directory, owner => 'root', group => 'root', recurse => true, source => 'puppet:///modules/role/statically_compiled', }   file { '/tmp/statically_compiled/test.txt': ensure => file, owner => 'root', content => "blah\n", } root@traveler:/usr/lib/ruby/vendor_ruby/puppet/indirector/file_metadata# service puppetmaster restart; puppet agent -t Restarting puppet master [ OK ] Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: File[/tmp/statically_compiled/test.txt] is already declared in file /etc/puppet/environments/production/modules/role/manifests/traveler.pp:27; cannot redeclare Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run the culprit is remove_existing_resources ... # Remove any file resources in the catalog that will be duplicated by the # given file resources. # # @param children [Array<Puppet::Resource>] # @param catalog [Puppet::Resource::Catalog] def remove_existing_resources(children, catalog) existing_names = catalog.resources.collect { |r| r.to_s } both = (existing_names & children.keys).inject({}) { |hash, name| hash[name] = true; hash } both.each { |name| children.delete(name) } end ... The intersection between existing_names and children.keys never matches anything because existing_names are stringified resource objects (e.g. File['/tmp/statically_compiled/test.txt']) and children.keys are relative path strings (e.g. 'test.txt.). The result is that the 'both' list (hash actually, but that injection looks pretty unnecessary to me) is always empty. Add Comment   This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.