Jira (PUP-4337) OpenBSD package provider does not correctly install packages

[Jasper Lievisse Adriaanse (JIRA)]

Title: Message Title

Jasper Lievisse Adriaanse commented on PUP-4337   Re: OpenBSD package provider does not correctly install packages Hi, Finally gotten around to looking into this. To be clear, the title seems to suggest nothing can be installed with the OpenBSD package provider, which is not true. There are however issues when trying to install packages that don't actually exist: Info: Applying configuration version '1440161319' Debug: Prefetching openbsd resources for package Debug: Executing '/usr/sbin/pkg_info -a' Debug: Executing '/usr/sbin/pkg_info sasquatch' Debug: Executing '/usr/sbin/pkg_info -I sasquatch' Debug: Executing '/usr/sbin/pkg_add -r sasquatch' Notice: /Stage[main]/Main/Package[sasquatch]/ensure: created Wether or not sasquatch exists in real life is another matter, but puppet should indeed fail instead of reporting the package has been installed. Note however: obsidian:2001 pup-4337 % doas pkg_add -r sasquatch Can't find sasquatch obsidian:2002 pup-4337 % echo $? 0 obsidian:2003 pup-4337 % And that's a bug in pkg_add(8). It should set the return value to something non-zero. I'll submit a PR shortly which results in: Error: pkg_add returned: Can't find sasquatch Error: /Stage[main]/Main/Package[sasquatch]/ensure: change from absent to present failed: pkg_add returned: Can't find sasquatch Notice: Finished catalog run in 4.65 seconds Add Comment   This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.