Jira (PUP-5127) unterminated c-style comment causes hang

[Adam Jacob Muller (JIRA)]

Title: Message Title

Adam Jacob Muller created an issue   Puppet / PUP-5127 unterminated c-style comment causes hang Issue Type: Bug Affects Versions: PUP 3.8.2 Assignee: Unassigned Created: 2015/08/31 7:49 PM Environment: Ubuntu 14.04 LTS master/agent Priority: Normal Reporter: Adam Jacob Muller In my manifest file for my node, I had an unterminated c-style comment: having a manifest file containing "/" is sufficient to cause this (though other stupid errors like terminating with another "/" or bad nesting can also trigger the bug). Tested with a simple: strace -fff puppet master --debug --no-daemonize --compile puppet-agent relevant strace output: [pid 3469] stat("/etc/puppet/environments/vagrant/manifests/puppet-agent.pp", {st_mode=S_IFREG|0644, st_size=5, ...}) = 0 [pid 3469] stat("/etc/puppet/environments/vagrant/manifests/puppet-agent.pp", {st_mode=S_IFREG|0644, st_size=5, ...}) = 0 [pid 3469] stat("/etc/puppet/environments/vagrant/manifests/puppet-agent.pp", {st_mode=S_IFREG|0644, st_size=5, ...}) = 0 [pid 3469] open("/etc/puppet/environments/vagrant/manifests/puppet-agent.pp", O_RDONLY) = 5 [pid 3469] fstat(5, {st_mode=S_IFREG|0644, st_size=5, ...}) = 0 [pid 3469] fstat(5, {st_mode=S_IFREG|0644, st_size=5, ...}) = 0 [pid 3469] ioctl(5, SNDCTL_TMR_TIMEBASE or SNDRV_TIMER_IOCTL_NEXT_DEVICE or TCGETS, 0x7fff7c8788e0) = -1 ENOTTY (Inappropriate ioctl for device) [pid 3469] fstat(5, {st_mode=S_IFREG|0644, st_size=5, ...}) = 0 [pid 3469] lseek(5, 0, SEEK_CUR) = 0 [pid 3469] read(5, " /*\n", 5) = 5 [pid 3469] read(5, "", 8192) = 0 [pid 3469] close(5) = 0 I was originally suspecting that it was trying to read() past EOF looking for the comment terminator (and perhaps it still is) but it looks like it hangs after close() Add Comment   This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.