Jira (PUP-5350) Puppet filter function does not behave consistently across all supported argument types.

[Peter Huene (JIRA)]

Title: Message Title

Peter Huene created an issue   Puppet / PUP-5350 Puppet filter function does not behave consistently across all supported argument types. Issue Type: Bug Affects Versions: PUP 4.2.2 Assignee: Unassigned Created: 2015/10/09 3:18 PM Fix Versions: PUP 4.3.0 Priority: Normal Reporter: Peter Huene The overload of the filter function that takes a Hash behaves differently from the other overloads that take an "enumerable" type. For example: notice({a => 1, b => 2, c => 3}.filter |$k, $v| { $v }) Will output {a => 1, b=> 2, c => 3} However: notice([1, 2, 3].filter |$v| { $v }) Will output: [] The first example returns an Integer and results in not filtering the element. The second example also returns an Integer, but this results in filtering the element. One of these behaviors is incorrect and should be made consistent. Cause of bug: Int the filter function's implementation, the Hash overload uses hash#select and returns the result of yielding to the lambda, which Ruby treats as true if the value is truthy. The enumerable overload instead has a direct comparison of the lambda's return value to true. Add Comment   This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.