Issue #1903 has been updated by Luke Kanies. Subject changed from Metaparams should no longer inherit to contained resources to Metaparam inheritance should not involve a recursive search Status changed from Accepted to Ready for Testing Target version changed from Statler to Rowlf Branch set to luke/tickets/master/1903-metaparam_searching_is_faster
Testing showed that the way we were doing metaparam inheritance (an upward recursive search) could sometimes take up to 70% of the compile time. This branch refactors the process to be drastically faster - we do one catalog walk. It might involve slightly more memory usage, because we're temporarily storing the data, but that's pretty well optimized, too. ---------------------------------------- Feature #1903: Metaparam inheritance should not involve a recursive search http://projects.puppetlabs.com/issues/1903 Author: Luke Kanies Status: Ready for Testing Priority: Normal Assigned to: Markus Roberts Category: language Target version: Rowlf Affected version: 0.24.7 Keywords: Branch: luke/tickets/master/1903-metaparam_searching_is_faster This feature was present because we weren't actually passing a real catalog to the client, only weird recursive structures. Now that, in 0.25, we'll be passing a real catalog, we can get rid of this. If someone specifies a relationship to or on a container object (class, definition, or node), that relationship is handled comfortably in the graph, so we don't need to worry about passing them on explicitly in the language. This should significantly clean up some currently messy code, but it will require a bit of diligence to make sure it all works correctly. I'm marking this for 0.25, but eh, it might get bumped. It's not *too* much work, since it's mostly about removing code and testing, but who knows. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
