Issue #3145 has been updated by James Turnbull.

Target version changed from 0.25.5 to 0.25.6


----------------------------------------
Bug #3145: Logging options are now out of date
http://projects.puppetlabs.com/issues/3145

Author: James Turnbull
Status: Accepted
Priority: Normal
Assigned to: James Turnbull
Category: plumbing
Target version: 0.25.6
Affected version: 0.25.4
Keywords: 
Branch: 


No code seems to use the following options:

masterlog, puppetdlog

The following test is the only place that mentions masterlog:

<pre>
        it "should use the masterlog if the process name is 'puppetmasterd'" do
            Puppet.settings.stubs(:value).with(:name).returns "puppetmasterd"
            Puppet.settings.expects(:value).with(:masterhttplog).returns 
"/master/log"

            File.expects(:open).with("/master/log", "a+").returns @filehandle

            @server.setup_logger
        end 

        it "should use the httplog if the process name is not 'puppetmasterd'" 
do
            Puppet.settings.stubs(:value).with(:name).returns "other"
            Puppet.settings.expects(:value).with(:httplog).returns "/other/log"

            File.expects(:open).with("/other/log", "a+").returns @filehandle

            @server.setup_logger
        end 
</pre>

If you reference the code:

<pre>
    def setup_logger
        # Make sure the settings are all ready for us.
        Puppet.settings.use(:main, :ssl, Puppet[:name])

        if Puppet[:name] == "puppetmasterd"
            file = Puppet[:masterhttplog]
        else
            file = Puppet[:httplog]
        end 
</pre>

I think the test means should use masterhttplog.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to