Jira (PUP-5395) There's no way to set resolution_type when using data bindings

[Thomas Hallgren (JIRA)]

Title: Message Title

Thomas Hallgren commented on PUP-5395   Re: There's no way to set resolution_type when using data bindings I question the use of a global parameter like hiera_advanced_parameter_bindings or data_binding_lookupoptions to control the behavior. If the intent is to make the lookup behavior an aspect of the data itself, then there should be no global override. Performance wise it shouldn't matter much if the behavior is instead controlled by checking the existence of the lookupoptions::* key. It has already been parsed into a hash. One thing that could make a small difference performance wise would be if we, instead of using a lookupoptions::* key, would use a lookupoptions key with an associated object where the subkeys are specified. That would avoid unnecessary string concatenations in order to build keys. E.g. instead of this: lookupoptions::mysql::server::override_options: merge: deep we could have this: lookupoptions: mysql::server::override_options: merge: deep Now the backend only needs to check of the presence of lookupoptions once and then use it's presence to control its behavior for all lookups. The actual key used for a lookup can also be used inside of the lookupoptions object. No more string concatenation. To really do a deep(er) merge will of course consume some more CPU-cycles but having a global flag to control this will not help. If the data layout was made with the intention of it being merged, then everything will crash if it's used some other way. Add Comment   This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.