Jira (PUP-5471) resource evaluation_time in report does not include time spent responding to events

[Reid Barton (JIRA)]

Title: Message Title

Reid Barton commented on PUP-5471   Re: resource evaluation_time in report does not include time spent responding to events The cause of the issue is simple: from `transaction.rb` # Apply all changes for a resource def apply(resource, ancestor = nil) status = resource_harness.evaluate(resource) add_resource_status(status) event_manager.queue_events(ancestor || resource, status.events) unless status.failed? rescue => detail resource.err "Could not evaluate: #{detail}" end   # Evaluate a single resource. def eval_resource(resource, ancestor = nil) if skip?(resource) resource_status(resource).skipped = true else resource_status(resource).scheduled = true apply(resource, ancestor) end   # Check to see if there are any events queued for this resource event_manager.process_events(resource) end The `evaluation_time` status field is measured and set inside `resource_harness.evaluate`, but responding to events happens later, in `event_manager.process_events`. Suggest setting the `evaluation_time` field in the same place that `--evaltrace` is processed, in `transaction.evaluate`, the caller of `eval_resource`: def evaluate(&block) ... if resource.is_a?(Puppet::Type::Component) Puppet.warning "Somehow left a component in the relationship graph" else resource.info "Starting to evaluate the resource" if Puppet[:evaltrace] and @catalog.host_config? seconds = thinmark { block.call(resource) } # Set resource_status(resource).evaluation_time here, not inside resource_harness.evaluate resource.info "Evaluated in %0.2f seconds" % seconds if Puppet[:evaltrace] and @catalog.host_config? end ... Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.