Jira (PUP-5422) Agent pidfile never removed in Solaris if there is no signed certificate

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-5422   Re: Agent pidfile never removed in Solaris if there is no signed certificate This issue is reproducible on all platforms if you run the agent daemonized, have autosigning disabled, forcing the agent to wait for the cert to be signed, and while it's daemonized, kill the process. In syslog, you'll see: Nov 5 15:42:34 arcturus puppet-agent[98771]: Could not run: SIGTERM While the agent pid file remains: $ bundle exec puppet agent $ cat /Users/josh/.puppetlabs/var/run/agent.pid 99933 $ cat /Users/josh/.puppetlabs/var/run/agent.pid 99933 With this fix, the agent registers its signal handlers before trying to wait for the cert, and gracefully exits: Nov 5 15:45:41 arcturus puppet-agent[99102]: Reopening log files Nov 5 15:45:59 arcturus puppet-agent[99102]: Caught TERM; exiting And the pid file is deleted: $ bundle exec puppet agent $ cat /Users/josh/.puppetlabs/var/run/agent.pid 422 $ kill -s TERM 422 $ cat /Users/josh/.puppetlabs/var/run/agent.pid cat: /Users/josh/.puppetlabs/var/run/agent.pid: No such file or directory Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.