Jira (FACT-1274) virtual/is_virtual does not detect docker anymore

[Maxence Dunnewind (JIRA)]

Title: Message Title

Maxence Dunnewind created an issue   Facter / FACT-1274 virtual/is_virtual does not detect docker anymore Issue Type: Bug Affects Versions: FACT 2.4.4 Assignee: Unassigned Components: Community Created: 2015/11/12 3:04 AM Environment: Host : ubuntu 15.10 Docker : 1.9.0 Docker container : Debian wheezy - facter 2.4.4 Labels: docker Priority: Normal Reporter: Maxence Dunnewind Inside a docker container (debian wheezy): root@docker1-wheezy:~# facter virtual physical root@docker1-wheezy:~# facter is_virtual false This is because output of cgroups in ubuntu 15.10 (at least) has changed: root@docker1-wheezy:~# cat /proc/1/cgroup 10:hugetlb:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 9:blkio:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 8:memory:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 7:perf_event:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 6:freezer:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 5:cpu,cpuacct:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 4:cpuset:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 3:devices:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 2:net_cls,net_prio:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope 1:name=systemd:/system.slice/docker-28c956314a24d47fdeac8455669aba0d9146dc5f48f12b28c676550e51d8d83b.scope So this does not match the : in_docker = path.readlines.any? {|l| l.split(":")[2].to_s.start_with? '/docker/' } in facter/util/virtual.rb anymore. I tested with : in_docker = path.readlines.any? {|l| l.split(":")[2].to_s =~ /\/docker/ } and it works correctly : root@docker1-wheezy:~# facter is_virtual true root@docker1-wheezy:~# facter virtual docker Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.