Jira (PUP-1455) Puppet should utilize CFPropertyList to read/write plist files

[Michael Smith (JIRA)]

Title: Message Title

Michael Smith commented on PUP-1455   Re: Puppet should utilize CFPropertyList to read/write plist files I had a theory that most of the benefit to this PR is not using plutil. Most of the time it's not necessary, and as we've seen there are a few files that are malformed where it's still useful as a fallback, so I gathered some benchmarks comparing using CFPropertyList (with plutil as a fallback for failures) vs using the existing Plist library but first trying it without plutil. The branches are https://github.com/MikaelSmith/puppet/tree/cfplist and https://github.com/MikaelSmith/puppet/tree/retryplutil. Mac OS X 10.9 (fresh VM) using Ruby 1.9.3-p551 CFPropertyList $ for a in {1..5}; do time bundle exec puppet resource service > /dev/null; done real 0m7.010s user 0m6.277s sys 0m0.663s real 0m6.906s user 0m6.264s sys 0m0.622s real 0m6.880s user 0m6.256s sys 0m0.605s real 0m6.830s user 0m6.205s sys 0m0.609s real 0m6.820s user 0m6.189s sys 0m0.607s RetryPlutil $ for a in {1..5}; do time bundle exec puppet resource service > /dev/null; done real 0m5.191s user 0m3.507s sys 0m1.585s real 0m4.986s user 0m3.534s sys 0m1.349s real 0m4.854s user 0m3.499s sys 0m1.268s real 0m4.839s user 0m3.542s sys 0m1.207s real 0m4.803s user 0m3.469s sys 0m1.241s Average real times with CFPropertyList are 6.889s, vs 4.935s with trying without plutil first. Mac OS X 10.10 (fresh VM) using Ruby 2.0.0-p647 CFPropertyList $ for a in {1..5}; do time bundle exec puppet resource service > /dev/null; done real 0m7.195s user 0m4.815s sys 0m0.889s real 0m5.256s user 0m4.662s sys 0m0.584s real 0m5.224s user 0m4.643s sys 0m0.575s real 0m5.317s user 0m4.699s sys 0m0.584s real 0m5.909s user 0m4.750s sys 0m0.610s RetryPlutil $ for a in {1..5}; do time bundle exec puppet resource service > /dev/null; done real 0m8.036s user 0m3.718s sys 0m2.525s real 0m8.453s user 0m3.770s sys 0m3.660s real 0m6.819s user 0m3.707s sys 0m2.990s real 0m5.615s user 0m3.736s sys 0m1.766s real 0m5.496s user 0m3.758s sys 0m1.605s Average real times with CFPropertyList are 5.780s, vs 6.884s with trying without plutil first. Mac OS X 10.11 (my laptop) using Ruby 2.1.7 CFPropertyList $ for a in {1..5}; do sudo time bundle exec puppet resource service > /dev/null; done 4.76 real 4.16 user 0.58 sys 4.74 real 4.18 user 0.55 sys 4.96 real 4.34 user 0.59 sys 5.31 real 4.63 user 0.65 sys 5.44 real 4.73 user 0.67 sys RetryPlutil $ for a in {1..5}; do sudo time bundle exec puppet resource service > /dev/null; done 4.78 real 3.15 user 1.58 sys 4.96 real 3.20 user 1.70 sys 4.94 real 3.28 user 1.60 sys 4.92 real 3.19 user 1.67 sys 5.07 real 3.30 user 1.70 sys Average real times with CFPropertyList are 5.04s, vs 4.93s with trying without plutil first. On Mac OS X 10.9 there are On Mac OS X 10.10 there are 458 services found, and 99 are binary. On Mac OS X 10.11 there are 529 services found, and 124 are binary. Given the inconclusive results, and that the changes required to use CFPropertyList are somewhat substantial, I'd rather use the much simpler change for a bug fix release. We can continue investigating using CFPropertyList in Puppet 4.4.0, assuming we can get demonstrably improved behavior. My conclusion from these tests is that there's significant overhead in using plutil to read text plists, but that it's just as fast or faster than CFPropertyList for binary files and the Plist library identifies and fails out of binary files very quickly. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.