Jira (PUP-5444) symbolic_modes tests occasionally fail on OSX

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-5444   Re: symbolic_modes tests occasionally fail on OSX There are a few problems. First, the test checks if the symuser and symgroup accounts for each combination of symbolic mode, which is wrong, it should only do that once for the entire test and use a teardown to clean up at the end. Second, the test uses beaker's Host#group_present method to see if the group exists: $ dscacheutil -q user -a name symgroup which seems to always return an empty string (at least on the last run). The test queries for the last known group id, adds one, and creates a new group with that id: k0inawy4ovsi1id.delivery.puppetlabs.net (agent) 15:39:59$ dscl . -list /Groups PrimaryGroupID | sort -k 2 -g | tail -1 | awk '{print $2}' 722   k0inawy4ovsi1id.delivery.puppetlabs.net (agent) executed in 0.04 seconds   k0inawy4ovsi1id.delivery.puppetlabs.net (agent) 15:39:59$ dscl . create /Groups/symgroup && dscl . create /Groups/symgroup PrimaryGroupID 723 It then runs the test chown'ing to that user and group: k0inawy4ovsi1id.delivery.puppetlabs.net (agent) 15:39:59$ touch /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/symbolic-modes.XXXXXX.V7TYohzS/file && chown symuser:symgroup /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/symbolic-modes.XXXXXX.V7TYohzS/file && chmod 2744 /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/symbolic-modes.XXXXXX.V7TYohzS/file But for some reason, after applying puppet, the file refers to a non-existent group: k0inawy4ovsi1id.delivery.puppetlabs.net (agent) 15:40:20$ env PATH="/opt/puppetlabs/puppet/bin:${PATH}" ruby -e 'require "etc"; puts (Etc.getgrgid(File.stat("/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/symbolic-modes.XXXXXX.V7TYohzS/file").gid).name)' -e:1:in `getgrgid': can't find group for 723 (ArgumentError) from -e:1:in `<main>' Where the resulting file has: k0inawy4ovsi1id:~ root# stat /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/symbolic-modes.XXXXXX.V7TYohzS/file 16777218 512770 -rwxr--r-- 1 symuser (723) 0 0 "Nov 16 15:40:14 2015" "Nov 16 15:40:14 2015" "Nov 16 15:40:20 2015" "Nov 16 15:40:14 2015" 4096 0 0 /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/symbolic-modes.XXXXXX.V7TYohzS/file The test should just use puppet to create the user and group as we're not testing the user & group providers in this test. For example, using puppet correctly creates the group and is idempotent: k0inawy4ovsi1id:~ root# /opt/puppetlabs/bin/puppet resource group foobar ensure=present --debug ... Debug: Executing: '/usr/bin/dscl -plist . -list /Groups' Debug: Executing: '/usr/bin/dscl -plist . -list /Groups' Debug: Executing: '/usr/bin/dscl -plist . -create /Groups/foobar GeneratedUID 1D0C6B8B-7ACE-4514-B8C9-C1F28C19C0D7' Debug: Executing: '/usr/bin/dscl . -list /Groups gid' Debug: Executing: '/usr/bin/dscl -plist . -create /Groups/foobar PrimaryGroupID 21' Notice: /Group[foobar]/ensure: created Debug: Finishing transaction 70123497720840 Debug: Storing state Debug: Stored state in 0.03 seconds Debug: Executing: '/usr/bin/dscl -plist . -list /Groups' Debug: Executing: '/usr/bin/dscl -plist . -read /Groups/foobar' group { 'foobar': ensure => 'present', } k0inawy4ovsi1id:~ root# /opt/puppetlabs/bin/puppet resource group foobar group { 'foobar': ensure => 'present', gid => '21', } But the command beaker is using, doesn't see the group: k0inawy4ovsi1id:~ root# dscacheutil -q user -a name foobar k0inawy4ovsi1id:~ root# Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.