Jira (PUP-5285) Systemd service provider only handles .service units, when others can be useful

[William Hopper (JIRA)]

Title: Message Title

William Hopper commented on PUP-5285   Re: Systemd service provider only handles .service units, when others can be useful Some notes from poking around with Puppet + Systemd: Currently, when we query or operate on a systemd unit without using fully-qualified service names (i.e, puppet resource service dnf-automatic), puppet invokes systemctl using the non-fully qualified service name by default, which is interpreted as the .service unit by systemd. For example, [root@bay7rtfgfm9dein ~]# puppet resource service dnf-automatic --verbose --debug ... Debug: Executing: '/usr/bin/systemctl is-active dnf-automatic' Debug: Executing: '/usr/bin/systemctl show dnf-automatic --property LoadState --property UnitFileState --no-pager' ... and if we run these commands manually, we see the following properties: [root@bay7rtfgfm9dein ~]# systemctl show dnf-automatic --no-pager ... Id=dnf-automatic.service Names=dnf-automatic.service ... Thus, putting the pieces together, by default Puppet interprets the service dnf-automatic as the dnf-automatic.service unit, which is the desired behavior, as Greg Sutcliffe mentioned above. The timer unit is fully distinct: [root@bay7rtfgfm9dein ~]# systemctl show dnf-automatic.timer --property LoadState --property Id --no-pager ... Id=dnf-automatic.timer LoadState=loaded ... All of this means that we will not suffer from ambiguity between services by removing the --type service option from our systemctl invocation. As far as I can tell, the only impact that change will have is to make non-service unit types discoverable from puppet resource service, which seems like the right thing to do. It should also be noted that timer units are already manageable through puppet (e.g, puppet resource service dnf-automatic.timer ensure=running will work correctly, as long as the fully qualified service name is provided). This change will simply make these services show up when querying all active systemd units on the system. I will put this change through all of our service acceptance tests in Fedora and Debian (since systemd is a bit weird on the Debian side). Also, as to Ed Marshall's concern about enable=false accidentally disabling the timer unit, I verified that this is not the case (as he did in subsequent comments). Providing no context about which unit type you are referring to in a manifest always defaults to the .service unit, so this shouldn't be a concern. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.