Jira (PUP-2315) function call error message about mis-matched arguments is hard to understand

[Rob Reynolds (JIRA)]

Title: Message Title

Rob Reynolds commented on PUP-2315   Re: function call error message about mis-matched arguments is hard to understand Module Testing Errors FYI: tl;dr: Puppet 4.3.x changed the validation message for missing parameters. You need to adjust your specs as noted at the very bottom. For anyone that ends up here in the future related to module testing, if you are suddenly getting specs failing related to checking missing values, something like Failure/Error: expect { catalogue }.to raise_error(error_class, error_message) expected Puppet::Error with message matching /Must\ pass\ user/, got #<Puppet::PreformattedError: Evaluation Error: Error while evaluating a Resource Statement, resourceName: expects a value for parameter 'user' at line 1 The commit that added the empty parameter check to the compiler was released in 4.3.0 - https://github.com/puppetlabs/puppet/commit/8c4a634cce1dc4f197ef27ddfa701a962beb8b32 Specifically https://github.com/puppetlabs/puppet/blob/42681420d93b984ca06073494bc1b4d70acf4e5e/lib/puppet/pops/types/type_mismatch_describer.rb#L150-L154 is where the check is at. This overrides the check at https://github.com/puppetlabs/puppet/blob/42681420d93b984ca06073494bc1b4d70acf4e5e/lib/puppet/resource.rb#L480 where it passes the previous error message (the puppet sha is latest stable as of this comment). To fix your specs, please update your error message validation as follows: if Puppet.version < '4.3.0' let(:error_message) { /Must pass user/ } else let(:error_message) { /expects a value for parameter 'user'/ } end Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.