Jira (PUP-5582) Enforce "no return in ensure block" rubocop

Kylo Ginsberg (JIRA) Tue, 08 Dec 2015 17:54:37 -0800

Title: Message Title

PUP-5582

On further reflection, I'm going to close this ticket. I misunderstood what ruby does and what the checker does.

From https://github.com/bbatsov/rubocop/issues/60, I found this description of the checker:

Never return from an ensure block. If you explicitly return from a method inside an ensure block, the return will take precedence over any exception being raised, and the method will return as if no exception had been raised at all. In effect, the exception will be silently thrown away.

However, I tried this snippet with both ruby 1.9.3 and ruby 2.2.0 and the exception is actually raised.

def thing

ensure

  raise Exception

  return "something else"

end

and it results in, say:

Exception: Exception

        from (irb):5:in `thing'

        from (irb):8

        from /usr/local/opt/rbenv/versions/1.9.3-p484/bin/irb:12:in `<main>'

So I'm not sure if this is an old ruby-ism or if I'm missing the point. But either way, it only showed up in one place in the puppet code base and doesn't seem to be doing harm, so I'm closing this for now as I've been sufficiently nerd-sniped

If someone else sees the error in my ways though, by all means open this back up.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-5582) Enforce "no return in ensure block" rubocop

Reply via email to