Jira (PUP-5595) Generated resource state is retrieved prematurely

[Reid Vandewiele (JIRA)]

Title: Message Title

Reid Vandewiele created an issue   Puppet / PUP-5595 Generated resource state is retrieved prematurely Issue Type: Bug Assignee: Unassigned Attachments: backtrace.txt, generated_resource.png, manual_resource.png Created: 2015/12/10 11:41 AM Priority: Normal Reporter: Reid Vandewiele Issue discovered while working with the lwf/remote_file type/provider. Remote_file generates a file resource to enforce owner, group and mode parameters. The following is an example use of the resource. remote_file { 'download': source => 'https://github.com/dimetron/vagrant_docker_dbora12c/archive/master.zip', path => "/tmp/linuxamd64_12102_database_1of2.zip", verify_peer => false, mode => '0644', } This worked as expected in Puppet 4.2.x However, in Puppet 4.3.1, there is a problem. This is the output from puppet applying this code. [reidmv@halcyon:~/] % puppet apply ~/src/tse-control-repo/test.pp Notice: Compiled catalog for halcyon.corp.puppetlabs.net in environment production in 0.06 seconds Notice: /Stage[main]/Main/Remote_file[download]/ensure: created Notice: /Stage[main]/Main/File[/tmp/linuxamd64_12102_database_1of2.zip]/ensure: created Notice: Applied catalog in 1.03 seconds [reidmv@halcyon:~/] % ls -l /tmp/linuxamd64_12102_database_1of2.zip -rw-r--r-- 1 reidmv staff 0 Dec 10 10:49 /tmp/linuxamd64_12102_database_1of2.zip [reidmv@halcyon:~/] % Notice that the generated File resource re-creates the file (as an empty file) rather than just changing the mode. If the code directly specifies Remote_file without mode (so no generated file resource) and the File resource explicitly, the behavior is as expected. remote_file { 'download': source => 'https://github.com/dimetron/vagrant_docker_dbora12c/archive/master.zip', path => "/tmp/linuxamd64_12102_database_1of2.zip", verify_peer => false, }   file { "download": path => "/tmp/linuxamd64_12102_database_1of2.zip", mode => '0644', } Then Puppet outputs the following on apply: [reidmv@halcyon:~/] % puppet apply ~/src/tse-control-repo/test.pp Notice: Compiled catalog for halcyon.corp.puppetlabs.net in environment production in 0.05 seconds Notice: /Stage[main]/Main/Remote_file[download]/ensure: created Notice: /Stage[main]/Main/File[download]/mode: mode changed '0600' to '0644' Notice: Applied catalog in 0.92 seconds [reidmv@halcyon:~/] % The generated file resource fails to correctly detect that the file already exists. We played around with pry for a bit trying to figure out what was going on and figured out that ensure’s retrieve method was called for the generated file before the remote_file resource was evaluated. The stacktrace from when retrieve is called in 4.3.1 with the generated resource is attached (ignore the line number on the top of the stack as it's off due to our debugging code). The resource graphs for each manifest are attached as well. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.