Jira (PUP-5502) lookup adapter "lookup_global" produces bad error message for faulty hiera.yaml

[Sean Griffin (JIRA)]

Title: Message Title

Sean Griffin commented on PUP-5502   Re: lookup adapter "lookup_global" produces bad error message for faulty hiera.yaml Tested on centos-6-x86_64. Puppet 4.3.2 Compared the fixed sha (d6b75bbd6016b36651c5013b2e7b692851f9b5bf) with the sha before the fix (5032dc977a1842650cbe5f58670ecab24784342e). The error message is now more concise and includes the name of the key on which the lookup failed. Both error message contain the name of and the location in the broken yaml file where evaluation failed. I tried it two ways, (1) with no module defined, invoking 'puppet lookup key_in_hiera' and (2) with a module, data_module, whose init.pp contains a call to lookup("key_in_hiera") and environment/production/site.pp declares the data_module class. Here is what the error message look like: 1: puppet lookup key_in_module Message from before fix: [root@vd1vgu8266rdkp0 environments]# puppet lookup key_in_hiera Error: Could not run: Error from DataBinding 'hiera' while looking up 'lookup_options': (/etc/puppetlabs/code/hiera.yaml): found character that cannot start any token while scanning for the next token at line 2 column 5 in (/etc/puppetlabs/code/hiera.yaml): found character that cannot start any token while scanning for the next token at line 2 column 5 Wrapped exception: (/etc/puppetlabs/code/hiera.yaml): found character that cannot start any token while scanning for the next token at line 2 column 5 in (/etc/puppetlabs/code/hiera.yaml): found character that cannot start any token while scanning for the next token at line 2 column 5 [root@vd1vgu8266rdkp0 environments]# Message from after fix: [root@e3zlx8t785l2dom environments]# puppet lookup key_in_hiera Error: Could not run: Lookup of key 'key_in_hiera' failed: DataBinding 'hiera': (/etc/puppetlabs/code/hiera.yaml): found character that cannot start any token while scanning for the next token at line 2 column 5 [root@e3zlx8t785l2dom environments]# 2. puppet apply /etc/puppetlabs/code/environments/production/manifests/site.pp Message from before fix: [root@vd1vgu8266rdkp0 puppetlabs]# puppet apply /etc/puppetlabs/code//environments/production/manifests/site.pp Notice: Scope(Class[Data_module]): Starting data_module init.pp { Error: Evaluation Error: Error while evaluating a Function Call, Error from DataBinding 'hiera' while looking up 'lookup_options': (/etc/puppetlabs/code/hiera.yaml): found character that cannot start any token while scanning for the next token at line 2 column 5 in (/etc/puppetlabs/code/hiera.yaml): found character that cannot start any token while scanning for the next token at line 2 column 5 at /etc/puppetlabs/code/environments/production/modules/data_module/manifests/init.pp:10:13 on node vd1vgu8266rdkp0.delivery.puppetlabs.net [root@vd1vgu8266rdkp0 puppetlabs]# Message from after fix: [root@e3zlx8t785l2dom puppetlabs]# puppet apply /etc/puppetlabs/code/environments/production/manifests/site.pp Notice: Scope(Class[Data_module]): Starting data_module init.pp { Error: Evaluation Error: Error while evaluating a Function Call, Lookup of key 'key_in_hiera' failed: DataBinding 'hiera': (/etc/puppetlabs/code/hiera.yaml): found character that cannot start any token while scanning for the next token at line 2 column 5 at /etc/puppetlabs/code/environments/production/modules/data_module/manifests/init.pp:10:13 on node e3zlx8t785l2dom.delivery.puppetlabs.net [root@e3zlx8t785l2dom puppetlabs]# Setup manifests for configuration with and without a module are attached. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.