Jira (HI-220) Deprecate interpolation via function in hiera.yaml

[Sean Griffin (JIRA)]

Title: Message Title

Sean Griffin commented on HI-220   Re: Deprecate interpolation via function in hiera.yaml It appears NO deprecation warning is issued when the user executes the hiera shell command. The command 'heira somekey' causes no deprecation warning. [root@qq9wi3yxlwklr7m roles]# hiera somekey someval [root@qq9wi3yxlwklr7m roles]# The deprecation warning is seen when the command 'puppet lookup somekey' is executed, or when either function hiera() or lookup() is called from a manifest. I am using puppet-agent build sha 9a1dfae64751da59ce8763730846669356da96dd for this test (http://builds.puppetlabs.lan/puppet-agent/9a1dfae64751da59ce8763730846669356da96dd/), installed by beaker. I retested using a simple manifest with no modules defined. The hiera configuration looks like this: /etc/puppetlabs/code/ ├── environments │   └── production ├── hieradata │   ├── global.yaml │   └── roles │   └── world.yaml └── hiera.yaml hiera.yaml: --- :backends: - "yaml" :logger: "console" :hierarchy: - "global" - "roles/%{hiera('hello')}"   :yaml: :datadir: "/etc/puppetlabs/code/hieradata" hieradata/global.yaml: --- hello: "world" hieradata/roles/world.yaml --- somekey: "someval" See attached file: hi-220-simple-init-manifest. In this configuration, global.yaml is searched first, facilitating lookup of "hello" (evaluates to "world"). Key: "somekey" is resolved in hieradata/roles/world.yaml without runaway recursion. In the fixed version I see the deprecation warning, then the correct value for the key ("someval"). 3 other observations: 1. The command 'puppet lookup somekey' results in 4 copies of the warning message. [root@qq9wi3yxlwklr7m roles]# puppet lookup somekey Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated --- someval ... [root@qq9wi3yxlwklr7m roles]# 2. The command: puppet apply -e "notice(hiera('somekey'))" results in two copies of the warning. [root@qq9wi3yxlwklr7m code]# puppet apply -e "notice(hiera('somekey'))" Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: Scope(Class[main]): someval Notice: Compiled catalog for qq9wi3yxlwklr7m.delivery.puppetlabs.net in environment production in 0.08 seconds Notice: Applied catalog in 0.02 seconds [root@qq9wi3yxlwklr7m code]# 3. The command: puppet apply -e "notice(lookup('somekey'))" results in four copies of the warning. [root@j8n2u9bp4askgom hieradata]# puppet apply -e "notice(lookup('somekey'))" Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: hiera(): Use of interpolation methods in hiera configuration file is deprecated Notice: Scope(Class[main]): someval Notice: Compiled catalog for j8n2u9bp4askgom.delivery.puppetlabs.net in environment production in 0.12 seconds Notice: Applied catalog in 0.03 seconds [root@j8n2u9bp4askgom hieradata]# Having previously established that the recursion error messages are properly improved, the only outstanding questions are: 1. Should hiera shell command generate a deprecation warning? 2. Though not serious, is the repeated deprecation warning expected? Tolerable? Easy or hard to fix? I just seems more presentable if the warning were displayed only once. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.