Jira (PUP-5634) Application declaration "nodes" parameter should accept string representation of nodes, components

[Reid Vandewiele (JIRA)]

Title: Message Title

Reid Vandewiele created an issue   Puppet / PUP-5634 Application declaration "nodes" parameter should accept string representation of nodes, components Issue Type: Improvement Assignee: Unassigned Created: 2015/12/22 12:03 PM Priority: Normal Reporter: Reid Vandewiele Description Currently, when declaring application instances in the Puppet DSL it is necessary for the nodes parameter to contain a hash of Resource[Node] type keys to Resource type or arrays of Resource type values. In order to allow for easier consumption of data from external sources, such as results of the lookup() function, the nodes parameter should also accept String representations of Resources, so long as they cleanly convert to valid Resource types. Example Use Case This is how application declarations are written in the DSL directly. rgbank { 'staging': web_count => 2, nodes => { Node['rgbank-appserver-01.pdx.puppetlabs.demo'] => [ Rgbank::Web['staging-0'] ], Node['rgbank-appserver-02.pdx.puppetlabs.demo'] => [ Rgbank::Web['staging-1'] ], Node['rgbank-loadbalancer-01.pdx.puppetlabs.demo'] => [ Rgbank::Load['staging'] ], Node['rgbank-database-01.pdx.puppetlabs.demo'] => [ Rgbank::Db['staging'] ], }, } When consuming data from an external source, such as Hiera, the same application instance as well as another called "dev" might be defined in YAML or some other serialized data format. E.g. --- applications: rgbank: dev: nodes: 'Node[rgbank-dev.pdx.puppetlabs.demo]': - 'Rgbank::Web[staging-0]' - 'Rgbank::Load[staging]' - 'Rgbank::Db[staging]' staging: web_count: 2 nodes: 'Node[rgbank-appserver-01.pdx.puppetlabs.demo]': - 'Rgbank::Web[staging-0]' 'Node[rgbank-appserver-02.pdx.puppetlabs.demo]': - 'Rgbank::Web[staging-1]' 'Node[rgbank-loadbalancer-01.pdx.puppetlabs.demo]': - 'Rgbank::Load[staging]' 'Node[rgbank-database-01.pdx.puppetlabs.demo]': - 'Rgbank::Db[staging]' Rather than writing all the application instances directly in a Puppet manifest a user might want to dynamically declare them based on the external data source using code such as the following in their site.pp site.pp site { $applications = lookup('applications')   $applications.each |String $type, Hash $instances| { $instances.each |String $title, Hash $params| { Resource[$type] { $title: * => $params, } } } } Today this can't work easily because there is no way to represent Puppet-specific types in standardized structured data formats (like JSON or YAML). As a workaround a function can be used to walk the data structure and return a copy in which all compatible string representations of resources have been converted to Resource types. See https://forge.puppetlabs.com/tse/to_resource for an example. Rather than requiring manual munging of data to support this use case, the application instance declaration itself should be able to analyze the nodes parameter and automatically accept compatible string-form representations of resources as valid input. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.