Issue #2910 has been updated by Markus Roberts.

Status changed from Needs design decision to Ready for Testing
Assigned to changed from James Turnbull to Markus Roberts
Branch set to http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/2910

I've changed matches to require an explicit recurse, on the Principle of Least 
Surprise (see the attached branch) but in testing it I noticed something else; 
unless the path ends in "/" the recursion seems to be ignored.  Thus:

<pre>
     tidy { tidy_tmp:
          path => "/tmp/",
          recurse => 1,
          matches => [ "jna*.tmp" ],
          age => "7d",
          backup => false
     }
</pre>

works but:

<pre>
     tidy { tidy_tmp:
          path => "/tmp",
          recurse => 1,
          matches => [ "jna*.tmp" ],
          age => "7d",
          backup => false
     }
</pre>

doesn't.  This seems wrong to me, but may serve some deeper purpose.  Since the 
actual recursion is being done by the file serving code, I'm reluctant to just 
"fix" it without greater understanding of what's going on.

----------------------------------------
Bug #2910: tidy failing to remove any matching files
http://projects.puppetlabs.com/issues/2910

Author: Peter Couvares
Status: Ready for Testing
Priority: High
Assigned to: Markus Roberts
Category: tidy
Target version: 0.25.5
Affected version: 0.25.4
Keywords: 
Branch: http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/2910


I'm somehow unable to get tidy to work _at all_ -- here is what I'm specifying, 
right inside a node definition in nodes.pp:
<pre>
     tidy { tidy_tmp:
          path => "/tmp/",
          age => "7d",
          backup => false,
          matches => [ "jna*.tmp" ],
     }
</pre>

The rest of my node definition, and everything else in nodes.pp more generally, 
works fine -- but matching files are not being tidied.

I can confirm many matching files on the client host in question with:

<pre>
find /tmp -maxdepth 1 -name 'jna*.tmp' -atime +7 -print
</pre>

I've tried the following in turn, with no luck:
* removing the matches attribute altogether,
* removing the age attribute altogether,
* replacing the matches list with a simple string,
* removing the explicit path attribute and using "/tmp" as the name,
* and setting the type attribute to "mtime" instead of the default atime.

I'm out of ideas, no one on IRC had any other ideas, and so I now suspect a bug.

If I'm doing something foolish, however, I'd be grateful to know.  Thanks.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to