Issue #2782 has been updated by Markus Roberts. Status changed from Ready for Testing to Code Insufficient Assigned to changed from James Turnbull to Markus Roberts
I'm marking this "Code Insufficient" for want of a better designation, and assigning it to me self for eventual resolution. While we need to address the issues this branch is addressing, the present branch: 1. Contains fragments of an older version of #2781 2. Does not merge cleanly on master 3. Duplicates some of the changes that are being made in the code smell process 4. Fixes things in ways that don't make sense (e.g. guarding @resource.stat(false) with a version check when none of the stat methods took a boolean parameter even in 1.8) My intent is to manually go through the changes after the dust settles and come up with a patch that addresses the things that need to be fixed with a new branch, perhaps based on this one. ---------------------------------------- Bug #2782: Changes in Ruby 1.9.x const_set and const_get prevent puppetd from properly executing http://projects.puppetlabs.com/issues/2782 Author: Al Hoang Status: Code Insufficient Priority: Low Assigned to: Markus Roberts Category: unknown Target version: Rowlf Affected version: 0.25.1 Keywords: Ruby 1.9 Branch: http://github.com/hoanga/puppet/tree/0.25.x_1.9.1 Hello, Attached is a patch with modifications to get puppetd to properly execute when puppetd --trace --verbose --debug is run on the command line. Some changes are: * Explicitly use the top-level File object in lib/puppet/type/file.rb * Add some checks on RUBY_VERSION and avoid called @resource.stat(false) * Call a Ruby 1.8.x compatible version of const_defined? if RUBY_VERSION looks like it is 1.9.x Here are some useful links that might help explain some of the changes to const_set and const_set in Ruby 1.9.x: http://issues.apache.org/jira/browse/BUILDR-140 http://jira.codehaus.org/browse/JRUBY-4197 http://redmine.ruby-lang.org/issues/show/1915 http://markmail.org/message/zr5vh2333yr3k3qi Please note that this assumes that the changes from ticket #2781 are already applied -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
