Jira (PUP-5726) Non-English values for USERNAME and USERPROFILE causes multiple home directories to be created

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown commented on PUP-5726   Re: Non-English values for USERNAME and USERPROFILE causes multiple home directories to be created Glenn Sarti and I discussed. It looks like there are very few touch points around the Puppet::Util.withenv function implemented at https://github.com/puppetlabs/puppet/blob/0730dac3985f72b24f050fefc1cc0820760586b5/lib/puppet/util.rb#L26-L40 which appears to be a problem spot for Ruby. I think we can safely / in a backward compatible way use the GetEnvironmentStrings API call to capture / restore the environment on Windows. This should probably be implemented inside puppet\\util\\windows process.rb It looks like execpipe at https://github.com/puppetlabs/puppet/blob/0730dac3985f72b24f050fefc1cc0820760586b5/lib/puppet/util/execution.rb#L79, execute_windows at https://github.com/puppetlabs/puppet/blob/0730dac3985f72b24f050fefc1cc0820760586b5/lib/puppet/util/execution.rb#L79 and checkexe in the exec provider for Windows https://github.com/puppetlabs/puppet/blob/0730dac3985f72b24f050fefc1cc0820760586b5/lib/puppet/provider/exec/windows.rb#L48 are the touch points (in addition to modifying a few tests and writing a few new tests). Also worth checking the existing PowerShell module to see if it leverages the underlying Puppet code or not. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.