Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet

Gareth Rushgrove (JIRA) Fri, 22 Jan 2016 07:26:21 -0800

Title: Message Title

PUP-5743

Posting the upstream bug so everything is in one place:

I hit an issue this morning with the Docker module in Travis where a single test (which had previously passed) failed, but only under the newly released Puppet 3.8.5 (released January 21st). This was also reported independently by another contributor garethr/garethr-docker#396.

Running the test on it's own see's it pass. Testing with previously passing code fails. Testing with rspec-puppet master and with 2.3 also fails. As suggested by @DavidS I tried 2.2 and this allowed the test to pass.

After much spelunking I was able to get a small test case which reliably recreates the failure.

require 'spec_helper'

describe 'docker::run', :type => :define do

  let(:title) { 'sample' }

  context 'passing the required params' do

    let(:facts) { {:osfamily => 'Archlinux'} }

    let(:params) { {'command' => 'command', 'image' => 'base'} }

    initscript = '/etc/systemd/system/docker-sample.service'

    # The first 16 tests will pass. The rest will fail on Puppet 3.8.5 with

    # NoMethodError:

    # undefined method `resource' for nil:NilClass

    # /Users/garethr/.rvm/gems/ruby-2.1.5/bundler/gems/rspec-puppet-7ab588ecdd1e/lib/rspec-puppet/matchers/create_generic.rb:83:in `matches?'

    18.times do

      it { should contain_file(initscript).with_content(/docker run/).with_content(/command/) }

end

end

end

Note the magic number 16. Given that is the number of catalogues cached in rspec-puppet I think that's likely related. Whether this points to a bug in Puppet 3.8.5 which rspec-puppet is exposing, or whether it's rspec-puppet using a private API that's changed it's behaviour, or something else I'm unsure.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet

Reply via email to