Jira (PUP-5900) Global noop true should override resource noop=>false

[Daniel Parks (JIRA)]

Title: Message Title

Daniel Parks created an issue   Puppet / PUP-5900 Global noop true should override resource noop=>false Issue Type: Improvement Affects Versions: PUP 4.2.3, PUP 2.7.23 Assignee: Unassigned Created: 2016/02/15 1:01 AM Priority: Normal Reporter: Daniel Parks Running Puppet agent with --noop will make changes if a resource has noop => false set. This is entirely unintuitive. If I run Puppet with --noop, I definitely don't want it to make changes. I understand that pluginsync will run, and resources will be exported, but actually making changes seems particularly dangerous. What's worse is that this typically affects resources that are critical. If I'm explicitly managing noop for a resource, then it's a resource that could potentially break things if it were turned on, and it's something that I want to keep an eye on during everyday runs. If I'm getting ready to disable noop on that resource, and I've made any other changes, I'm going to run the agent with --noop to verify what it will do. For example, the code that bit me was: resources { 'user': purge => true, noop => ! $::profile::server::params::user_purge, unless_system_user => true, # Solaris uses high UIDs for system users: unless_uid => range(60000,65535), } I'm aware of the clientnoop fact; that code now uses: noop => $facts['clientnoop'] or ! $::profile::server::params::user_purge, There is an ancient, closed RedMine issue covering this: https://projects.puppetlabs.com/issues/20679 (assigned to Eric Sorenson) Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.